Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file/folder description (and other new features and bugfixes) #289

Open
wants to merge 28 commits into
base: master
Choose a base branch
from

Commits on May 10, 2015

  1. Revert "Fix first accented character of folders stripped out"

    This reverts commit 13d10be.
    Anarky committed May 10, 2015
    Configuration menu
    Copy the full SHA
    ed73d7d View commit details
    Browse the repository at this point in the history

Commits on May 17, 2015

  1. Configuration menu
    Copy the full SHA
    165f5de View commit details
    Browse the repository at this point in the history
  2. Fix all problematic basename calls in classes

    basename will strip the first character if it is accented.
    This commit add the mb_basename function, taken from https://bugs.php.net/bug.php?id=37268
    
    This fixes:
    - file renaming on upload when a file with the same name already exists
    - comments and permissions ("éa.jpg" and "a.jpg" used the same file for comments/permissions)
    - photospheres folder ("éPhotoSpheres" was matching "PhotoSpheres")
    - file and folder name on the right menu
    - file and folder name in the rename textbox
    - filename in the left menu, the header and the RSS file
    - filename when downloading a picture or a zip
    
    The only remaining problem is with the exif infos on the right menu, but it is an external call to exif_read_data().
    Anarky committed May 17, 2015
    Configuration menu
    Copy the full SHA
    0421118 View commit details
    Browse the repository at this point in the history
  3. Add title for buttons, with an option to deactivate it

    This add title for buttons on the ImageBar, RSS and right menubar.
    Anarky committed May 17, 2015
    Configuration menu
    Copy the full SHA
    a8dc332 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    04d91fe View commit details
    Browse the repository at this point in the history
  5. Display a spinner when loading a Photo Sphere

    The spinnger was generated on http://spiffygif.com/ with the following parameters:
    - 8 lines
    - corners 1.0
    - trail 50
    - rotate 0
    - no shadow, halo
    - black foreground, white background
    - length 0
    - width 10
    - radius 18
    
    Their license (at the bottom on the "Docs" tab) permits to use it on this project.
    Anarky committed May 17, 2015
    Configuration menu
    Copy the full SHA
    9c483b8 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    90a0b93 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    5a7abf4 View commit details
    Browse the repository at this point in the history
  8. AdminUpload: remove dead code

    Anarky committed May 17, 2015
    Configuration menu
    Copy the full SHA
    4325202 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    3e26bcf View commit details
    Browse the repository at this point in the history
  10. Javascript: disable hotkeys inside input and textarea tags

    Some keys (left, right, up, space, escape) are always listened, making writing
    or moving inside the rename input or comment textarea difficult.
    This fixes thibaud-rohmer#248.
    Anarky committed May 17, 2015
    Configuration menu
    Copy the full SHA
    1f9ee26 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2015

  1. Configuration menu
    Copy the full SHA
    772a0fa View commit details
    Browse the repository at this point in the history
  2. Comments: remove dead code

    Anarky committed May 19, 2015
    Configuration menu
    Copy the full SHA
    e455e7e View commit details
    Browse the repository at this point in the history
  3. ImagePanel: remove dead code

    Anarky committed May 19, 2015
    Configuration menu
    Copy the full SHA
    e5e97e8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c4ecb4d View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2015

  1. Menu::list_files(): fix the search with an option to list all the files

    Before this commit, Menu::list_files() was returning only files considered
    to be an image or a video, even with $hidden set to true.
    Now we can get all the files a directory contains with a new option, in case
    some code expects the previous behaviour.
    Anarky committed Jul 13, 2015
    Configuration menu
    Copy the full SHA
    961ad64 View commit details
    Browse the repository at this point in the history
  2. Admin::rec_del(): use the new Menu::list_files() option to delete *ev…

    …erything*
    
    Now that Menu::list_files() is fixed, we can use it to effectively delete
    everything, e.g. a thumbnail folder containing xml metadatas among others
    files.
    Anarky committed Jul 13, 2015
    Configuration menu
    Copy the full SHA
    6f37485 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4e6884b View commit details
    Browse the repository at this point in the history
  4. File::Type(): fix the return parameter when using a folder

    The return of self::Extension($file) was incorrectly checked, thus returning
    the 0 at the end of the function.
    This can cause problems, because `"foo" == 0` is true in PHP...
    Anarky committed Jul 13, 2015
    Configuration menu
    Copy the full SHA
    e0a9b4d View commit details
    Browse the repository at this point in the history
  5. Rename/delete metadatas on file or folder renaming/deletion

    When a file or folder was renamed or deleted, its metadatas (tokens,
    xml and thumbnail) were kept.
    This commit will keep the Thumbs directory consistent with the picture
    directory.
    Anarky committed Jul 13, 2015
    Configuration menu
    Copy the full SHA
    0c9b9fc View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e103acc View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    fb813e9 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    dd9e2b5 View commit details
    Browse the repository at this point in the history
  9. CSS: display #image_panel elements as table-rows

    There is now a new div (#image_panel_table) inside #image_panel, encompassing
    #bigimage and #image_bar.
    This change was made to have dynamic resizing inside #image_panel, which
    will help to display description (see next commit) with a variable height.
    
    It should not change the page rendering, with the exception of a picture
    displayed with a page height under 300px. Instead of reducing more and more
    #image_panel, now a scrollbar appears.
    Anarky committed Jul 13, 2015
    Configuration menu
    Copy the full SHA
    099e4b7 View commit details
    Browse the repository at this point in the history
  10. New feature: add a description to a folder or a picture

    This new feature is optional (but activated by default).
    A new option added to the right menu permits to write a description, displayed
    between the image/video and the navigation buttons, or under the header for a
    folder.
    When a description is empty, it is hidden using CSS to remove its padding.
    
    The Description class is based on the Comments class.
    Anarky committed Jul 13, 2015
    Configuration menu
    Copy the full SHA
    7d613a4 View commit details
    Browse the repository at this point in the history
  11. Update French translation

    Anarky committed Jul 13, 2015
    Configuration menu
    Copy the full SHA
    0a1970d View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2015

  1. Fix comments and description saving when they contain an ampersand

    When a comment or a description contained an ampersand, their saving was
    throwing a warning:
    "PHP Warning:  SimpleXMLElement::addChild(): unterminated entity reference"
    An XML with an empty content ("<content/>") was created.
    This fixes this problem; a thorough explanation can be read here:
    http://stackoverflow.com/a/555039
    Anarky committed Jul 30, 2015
    Configuration menu
    Copy the full SHA
    525cd35 View commit details
    Browse the repository at this point in the history
  2. Videos: take all available space, like images

    The change in Video.php to set a width was mandatory for 4:3 screens,
    otherwise the video stretched outside the screen.
    Anarky committed Jul 30, 2015
    Configuration menu
    Copy the full SHA
    63a407a View commit details
    Browse the repository at this point in the history