Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is it possible to set the album image? #317

Open
spassvogel opened this issue Oct 31, 2016 · 4 comments
Open

is it possible to set the album image? #317

spassvogel opened this issue Oct 31, 2016 · 4 comments

Comments

@spassvogel
Copy link

or is this always random?

@thibaud-rohmer
Copy link
Owner

It' s the first image (alphabetical order) it finds in the album that is
displayed.

On Mon, 31 Oct 2016 at 19:41 spassvogel [email protected] wrote:

or is this always random?


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#317, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AAgnQ6ZoXlv4IKOzR8BQaNs7uNW_BAA2ks5q5jZxgaJpZM4KlXAE
.

@spassvogel
Copy link
Author

Hi Thibaud!

Thank you so much for your response. It clarifies a lot, so as a workaround I guess I can prefix an image with an underscore or something to make it the album title.

However.. I think it would be very nice if one could manually select an image to be the album cover. I have to confess my PHP is kind of rusty, but if I do get it working are you willing to accept a merge request that does this? (if it lives up to your standards, of course)

@thibaud-rohmer
Copy link
Owner

Hey !

Well, thank you for using photoshow in the first place ;)

A lot of people request this change. If you manage to do it, I'll try to
find the time to review it (as you may have noticed on github, I usually
have very little time, especially for pull requests). I promise I'll do my
best to try to review it. For others that have pull requests pending : I'll
try this weekend, I should have some time at some point... ^^

On Wed, 2 Nov 2016 at 14:59 spassvogel [email protected] wrote:

Hi Thibaud!

Thank you so much for your response. It clarifies a lot, so as a
workaround I guess I can prefix an image with an underscore or something to
make it the album title.

However.. I think it would be very nice if one could manually select an
image to be the album cover. I have to confess my PHP is kind of rusty, but
if I do get it working are you willing to accept a merge request that does
this? (if it lives up to your standards, of course)


You are receiving this because you commented.

Reply to this email directly, view it on GitHub
#317 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAgnQ3OcdoQzpjo58oLp_elJ8onGyy4sks5q6JdFgaJpZM4KlXAE
.

@spassvogel
Copy link
Author

Actually, looking through the pull requests I see that some of them implement some sort of metadata of directories (by using an XML). This one looks promising: #289. That's quite useful also for setting the album image.

So I'm going to wait and hope it gets merged and work from there. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants