Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FastQC added as an optional module in all Illumina_PE and Illumina_SE workflows #260

Merged
merged 9 commits into from
Jan 4, 2024

Conversation

sage-wright
Copy link
Member

@sage-wright sage-wright commented Dec 7, 2023

Closes #282

🛠️ Changes Being Made

  • FastQC is now included as part of the read_QC_trim_pe and read_QC_trim_se sub-workflows, and their associated parent workflows. fastq_scan is the default module. To use fastqc, the user must fill in "fastqc" for the new read_QC_trim.read_qc variable.

Impacted Workflows/Tasks

  • TheiaCoV_Illumina_PE
  • TheiaCoV_Illumina_SE
  • TheiaProk_Illumina_PE
  • TheiaProk_Illumina_SE
  • TheiaMeta_Illumina_PE
  • Freyja_FASTQ

🧠 Context and Rationale

FastQC was requested by a user.

📋 Workflow/Task Steps

Instead of defaulting to fastq_scan, the user can optionally use fastqc instead.

Inputs

One new input:

  • read_qc_trim.read_qc: default to "fastq_scan", can be manually modified to "fastqc"

Outputs

Several new outputs:

For all _Illumina_PE workflows (and Freyja_FASTQ):

  • fastqc_num_reads_raw1
  • fastqc_num_reads_raw2
  • fastqc_num_reads_raw_pairs
  • fastqc_raw1_html
  • fastqc_raw2_html
  • fastqc_version
  • fastqc_num_reads_clean1
  • fastqc_num_reads_clean2
  • fastqc_num_reads_clean_pairs
  • fastqc_clean1_html
  • fastqc_clean2_html

For all _Illumina_SE workflows:

  • fastqc_num_reads_raw
  • fastqc_num_reads_clean
  • fastqc_version
  • fastqc_raw_html
  • fastqc_clean_html

Impacted Outputs

All original fastq_scan outputs will be blank if fastqc was chosen. These include the following:

  • num_reads_raw1
  • num_reads_raw2
  • num_reads_raw_pairs
  • fastq_scan_version
  • num_reads_clean1
  • num_reads_clean2
  • num_reads_clean_pairs

🧪 Testing

Locally

Local tests of the fastqc tasks worked.

Terra

Using fastqc:

With nothing in the read_qc variable:

Scenarios for Reviewer to Test

  • All six workflows with fastqc on and off.

🔬 Quality checks

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The workflow/task has been tested locally and on Terra
  • The CI/CD has been adjusted and tests are passing
  • Everything follows the style guide

@kapsakcj kapsakcj self-requested a review December 20, 2023 19:35
@cimendes cimendes self-requested a review January 3, 2024 16:38
tasks/quality_control/task_fastqc.wdl Outdated Show resolved Hide resolved
@cimendes cimendes merged commit 7251599 into main Jan 4, 2024
17 checks passed
@sage-wright sage-wright deleted the smw-fastqc-dev branch January 4, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add FastQC as an optional module
2 participants