FastQC added as an optional module in all Illumina_PE and Illumina_SE workflows #260
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #282
🛠️ Changes Being Made
read_QC_trim_pe
andread_QC_trim_se
sub-workflows, and their associated parent workflows.fastq_scan
is the default module. To usefastqc
, the user must fill in"fastqc"
for the newread_QC_trim.read_qc
variable.Impacted Workflows/Tasks
🧠 Context and Rationale
FastQC was requested by a user.
📋 Workflow/Task Steps
Instead of defaulting to
fastq_scan
, the user can optionally usefastqc
instead.Inputs
One new input:
read_qc_trim.read_qc
: default to"fastq_scan"
, can be manually modified to"fastqc"
Outputs
Several new outputs:
For all _Illumina_PE workflows (and Freyja_FASTQ):
fastqc_num_reads_raw1
fastqc_num_reads_raw2
fastqc_num_reads_raw_pairs
fastqc_raw1_html
fastqc_raw2_html
fastqc_version
fastqc_num_reads_clean1
fastqc_num_reads_clean2
fastqc_num_reads_clean_pairs
fastqc_clean1_html
fastqc_clean2_html
For all _Illumina_SE workflows:
fastqc_num_reads_raw
fastqc_num_reads_clean
fastqc_version
fastqc_raw_html
fastqc_clean_html
Impacted Outputs
All original fastq_scan outputs will be blank if
fastqc
was chosen. These include the following:num_reads_raw1
num_reads_raw2
num_reads_raw_pairs
fastq_scan_version
num_reads_clean1
num_reads_clean2
num_reads_clean_pairs
🧪 Testing
Locally
Local tests of the
fastqc
tasks worked.Terra
Using
fastqc
:With nothing in the
read_qc
variable:Scenarios for Reviewer to Test
fastqc
on and off.🔬 Quality checks
Pull Request (PR) checklist: