Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bits of the Spanish translation #1

Closed
wants to merge 1 commit into from

Conversation

peterjc
Copy link

@peterjc peterjc commented Oct 26, 2018

I am assuming these are left overs from setting up the Japanese repository based on the Spanish translations, and can be removed.

@dpshelio
Copy link

If this is to merge with upstream - at the moment scarpentry-i18n/i18n, but under carpentries in the future - we shouldn't remove the Spanish files. The idea is that this repository works as a hub for all the (see carpentries/lesson-infrastructure#24)

@peterjc
Copy link
Author

peterjc commented Oct 26, 2018

That makes more sense now, thanks - presumably I missed something documenting this. Shall I close this?

@TomKellyGenetics
Copy link
Member

There are some remnants from the Spanish lessons in the Japanese.

There is a related issue to ensure that the PO files only generate English-Japanese and not Spanish-Japanese (or all languages already in the repo)
carpentries-i18n#6

@peterjc peterjc deleted the remove_es_files branch October 26, 2018 13:56
rikutakei pushed a commit that referenced this pull request Nov 18, 2018
joelnitta pushed a commit that referenced this pull request Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants