Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move the panic catch into the compile sierra to casm method #318

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

ArniStarkware
Copy link
Contributor

@ArniStarkware ArniStarkware commented Aug 5, 2024

This change is Reviewable

@ArniStarkware ArniStarkware marked this pull request as ready for review August 5, 2024 08:29
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/expose_compilation_args branch from db6c928 to bd04a7e Compare August 5, 2024 14:11
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/move_catch_into_util branch from f06bbeb to 33ea51c Compare August 5, 2024 14:12
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/expose_compilation_args branch from bd04a7e to c55f0be Compare August 6, 2024 11:22
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/move_catch_into_util branch from 33ea51c to f9dd325 Compare August 6, 2024 11:22
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/expose_compilation_args branch from c55f0be to 79ec169 Compare August 6, 2024 12:08
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/move_catch_into_util branch from f9dd325 to bb73e86 Compare August 6, 2024 12:08
Copy link
Collaborator

@dafnamatsry dafnamatsry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Yael-Starkware)

@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/expose_compilation_args branch from 79ec169 to 8bf1bdf Compare August 6, 2024 14:02
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/move_catch_into_util branch from bb73e86 to 2007594 Compare August 6, 2024 14:02
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/expose_compilation_args branch from 8bf1bdf to 98c3439 Compare August 6, 2024 14:36
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/move_catch_into_util branch from 2007594 to 7301e68 Compare August 6, 2024 14:36
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/expose_compilation_args branch from 98c3439 to 74dd64e Compare August 7, 2024 05:14
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/move_catch_into_util branch from 7301e68 to 47853d8 Compare August 7, 2024 05:14
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/expose_compilation_args branch from 74dd64e to a0d234f Compare August 7, 2024 07:02
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/move_catch_into_util branch from 47853d8 to dc09147 Compare August 7, 2024 07:02
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/expose_compilation_args branch from a0d234f to 734a4b7 Compare August 7, 2024 07:06
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/move_catch_into_util branch from dc09147 to 94b3990 Compare August 7, 2024 07:06
Copy link
Collaborator

@dafnamatsry dafnamatsry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Yael-Starkware)

@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/expose_compilation_args branch from 734a4b7 to ae56362 Compare August 7, 2024 10:29
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/move_catch_into_util branch from 94b3990 to 8bd0c70 Compare August 7, 2024 10:29
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/expose_compilation_args branch from ae56362 to cb4fef6 Compare August 7, 2024 12:06
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/move_catch_into_util branch from 8bd0c70 to b5e6627 Compare August 7, 2024 12:06
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/expose_compilation_args branch from cb4fef6 to 59228b7 Compare August 7, 2024 12:52
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/move_catch_into_util branch from b5e6627 to b2cbef7 Compare August 7, 2024 12:52
Copy link
Contributor Author

ArniStarkware commented Aug 8, 2024

Merge activity

@ArniStarkware ArniStarkware changed the base branch from arni/declare/compilation/expose_compilation_args to graphite-base/318 August 8, 2024 09:48
@ArniStarkware ArniStarkware changed the base branch from graphite-base/318 to main August 8, 2024 09:48
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/move_catch_into_util branch from b2cbef7 to 1a85036 Compare August 8, 2024 09:49
@ArniStarkware ArniStarkware merged commit 446ea9e into main Aug 8, 2024
11 checks passed
@ArniStarkware ArniStarkware mentioned this pull request Aug 8, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2024
@ArniStarkware ArniStarkware deleted the arni/declare/compilation/move_catch_into_util branch August 13, 2024 07:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants