Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename max_raw_class_size to max_contract_class_object_size #355

Conversation

ArniStarkware
Copy link
Contributor

@ArniStarkware ArniStarkware commented Aug 7, 2024

This change is Reviewable

Copy link
Contributor Author

ArniStarkware commented Aug 7, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ArniStarkware and the rest of your teammates on Graphite Graphite

@ArniStarkware ArniStarkware marked this pull request as ready for review August 7, 2024 12:08
@ArniStarkware ArniStarkware force-pushed the arni/declare/validation/rename_total_size_validation branch from 3531483 to d172ab0 Compare August 7, 2024 12:53
@ArniStarkware ArniStarkware force-pushed the arni/declare/validation/rename_total_sierra_size_validation branch from 61095c0 to 26f3acc Compare August 7, 2024 12:53
@ArniStarkware ArniStarkware force-pushed the arni/declare/validation/rename_total_size_validation branch from d172ab0 to 314fa55 Compare August 7, 2024 13:06
@ArniStarkware ArniStarkware force-pushed the arni/declare/validation/rename_total_sierra_size_validation branch from 26f3acc to af8ccea Compare August 7, 2024 13:06
@ArniStarkware ArniStarkware force-pushed the arni/declare/validation/rename_total_size_validation branch from 314fa55 to bbd7fb7 Compare August 8, 2024 10:05
@ArniStarkware ArniStarkware force-pushed the arni/declare/validation/rename_total_sierra_size_validation branch from af8ccea to 6f48721 Compare August 8, 2024 10:05
@ArniStarkware ArniStarkware force-pushed the arni/declare/validation/rename_total_size_validation branch from bbd7fb7 to b609eea Compare August 8, 2024 11:15
@ArniStarkware ArniStarkware force-pushed the arni/declare/validation/rename_total_sierra_size_validation branch from 6f48721 to 9e15c94 Compare August 8, 2024 11:15
@ArniStarkware ArniStarkware force-pushed the arni/declare/validation/rename_total_size_validation branch from b609eea to e6d424d Compare August 8, 2024 12:05
@ArniStarkware ArniStarkware force-pushed the arni/declare/validation/rename_total_sierra_size_validation branch from 9e15c94 to 442c50e Compare August 8, 2024 12:05
@ArniStarkware ArniStarkware force-pushed the arni/declare/validation/rename_total_size_validation branch from e6d424d to d4d38be Compare August 11, 2024 08:07
@ArniStarkware ArniStarkware force-pushed the arni/declare/validation/rename_total_sierra_size_validation branch from 442c50e to 61d3f9a Compare August 11, 2024 08:07
@ArniStarkware ArniStarkware force-pushed the arni/declare/validation/rename_total_size_validation branch from d4d38be to c8cbd4f Compare August 11, 2024 08:17
@ArniStarkware ArniStarkware force-pushed the arni/declare/validation/rename_total_sierra_size_validation branch from 61d3f9a to 7d3738b Compare August 11, 2024 08:17
@ArniStarkware ArniStarkware force-pushed the arni/declare/validation/rename_total_size_validation branch from c8cbd4f to f2e4797 Compare August 12, 2024 07:20
@ArniStarkware ArniStarkware force-pushed the arni/declare/validation/rename_total_sierra_size_validation branch from 7d3738b to 4c69929 Compare August 12, 2024 07:21
@ArniStarkware ArniStarkware force-pushed the arni/declare/validation/rename_total_size_validation branch from f2e4797 to 9547f5d Compare August 12, 2024 07:43
@ArniStarkware ArniStarkware force-pushed the arni/declare/validation/rename_total_sierra_size_validation branch from 4c69929 to 249445e Compare August 12, 2024 07:43
@ArniStarkware ArniStarkware force-pushed the arni/declare/validation/rename_total_sierra_size_validation branch from 249445e to befe24e Compare August 12, 2024 09:32
@ArniStarkware ArniStarkware changed the base branch from arni/declare/validation/rename_total_size_validation to main August 12, 2024 09:32
Copy link
Contributor

@yair-starkware yair-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dafnamatsry)

@ArniStarkware ArniStarkware merged commit e783edf into main Aug 15, 2024
19 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 17, 2024
@ArniStarkware ArniStarkware deleted the arni/declare/validation/rename_total_sierra_size_validation branch September 22, 2024 11:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants