Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gateway): rename cairo_lang_compiler file #330

Merged

Conversation

ArniStarkware
Copy link
Contributor

@ArniStarkware ArniStarkware commented Aug 5, 2024

This change is Reviewable

Copy link
Contributor

@Yael-Starkware Yael-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dafnamatsry)

@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/hide_behind/trait branch from 5dcbcde to d27096d Compare August 6, 2024 11:22
@ArniStarkware ArniStarkware force-pushed the arni/gateway/sierra_to_casm/refactor/rename_compiler branch from 97cb2c1 to 5a926bc Compare August 6, 2024 11:23
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/hide_behind/trait branch from d27096d to 6bc1920 Compare August 6, 2024 12:08
@ArniStarkware ArniStarkware force-pushed the arni/gateway/sierra_to_casm/refactor/rename_compiler branch from 5a926bc to ceb0705 Compare August 6, 2024 12:08
Copy link
Collaborator

@dafnamatsry dafnamatsry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)

@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/hide_behind/trait branch from 6bc1920 to 4073878 Compare August 6, 2024 14:02
@ArniStarkware ArniStarkware force-pushed the arni/gateway/sierra_to_casm/refactor/rename_compiler branch from ceb0705 to a357566 Compare August 6, 2024 14:02
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/hide_behind/trait branch from 4073878 to c0a8510 Compare August 6, 2024 14:36
@ArniStarkware ArniStarkware force-pushed the arni/gateway/sierra_to_casm/refactor/rename_compiler branch from a357566 to faf29e3 Compare August 6, 2024 14:36
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/hide_behind/trait branch from c0a8510 to a0d2098 Compare August 7, 2024 05:14
@ArniStarkware ArniStarkware force-pushed the arni/gateway/sierra_to_casm/refactor/rename_compiler branch from faf29e3 to 1427c61 Compare August 7, 2024 05:14
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/hide_behind/trait branch from a0d2098 to 636aeaf Compare August 7, 2024 07:02
@ArniStarkware ArniStarkware force-pushed the arni/gateway/sierra_to_casm/refactor/rename_compiler branch from 1427c61 to ea250fb Compare August 7, 2024 07:02
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/hide_behind/trait branch from 636aeaf to 4bf529f Compare August 7, 2024 07:06
@ArniStarkware ArniStarkware force-pushed the arni/gateway/sierra_to_casm/refactor/rename_compiler branch from ea250fb to 68f08ae Compare August 7, 2024 07:06
Copy link
Collaborator

@dafnamatsry dafnamatsry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Yael-Starkware)

@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/hide_behind/trait branch from 4bf529f to 57ba7f0 Compare August 7, 2024 10:29
@ArniStarkware ArniStarkware force-pushed the arni/gateway/sierra_to_casm/refactor/rename_compiler branch from 68f08ae to 0448d72 Compare August 7, 2024 10:29
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/hide_behind/trait branch from 57ba7f0 to 2c2df79 Compare August 7, 2024 12:06
@ArniStarkware ArniStarkware force-pushed the arni/gateway/sierra_to_casm/refactor/rename_compiler branch from 0448d72 to e5973fd Compare August 7, 2024 12:06
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/hide_behind/trait branch from 2c2df79 to 200dae4 Compare August 7, 2024 12:52
@ArniStarkware ArniStarkware force-pushed the arni/gateway/sierra_to_casm/refactor/rename_compiler branch from e5973fd to 989141e Compare August 7, 2024 12:53
Copy link
Contributor Author

ArniStarkware commented Aug 8, 2024

Merge activity

@ArniStarkware ArniStarkware changed the base branch from arni/declare/compilation/hide_behind/trait to graphite-base/330 August 8, 2024 09:56
@ArniStarkware ArniStarkware changed the base branch from graphite-base/330 to main August 8, 2024 10:01
@ArniStarkware ArniStarkware force-pushed the arni/gateway/sierra_to_casm/refactor/rename_compiler branch from 989141e to 0d74a87 Compare August 8, 2024 10:03
@ArniStarkware ArniStarkware merged commit 78580c8 into main Aug 8, 2024
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2024
@ArniStarkware ArniStarkware deleted the arni/gateway/sierra_to_casm/refactor/rename_compiler branch August 13, 2024 07:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants