chore(consensus): all tasks must be awaited to propogate panics #2958
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This was referenced Dec 25, 2024
matan-starkware
force-pushed
the
matan/consensus/milestone3/return_error_from_shc_decision
branch
from
3ee72d1 to
4cfdc84
Compare
matan-starkware
force-pushed
the
matan/consensus/milestone3/await_build_proposal_task
branch
from
8783230 to
5242c90
Compare
matan-starkware
changed the base branch from
matan/consensus/milestone3/return_error_from_shc_decision
to
main
matan-starkware
force-pushed
the
matan/consensus/milestone3/await_build_proposal_task
branch
from
5242c90 to
c0622f5
Compare
matan-starkware
changed the base branch from
main
to
matan/consensus/milestone3/return_error_from_shc_decision
matan-starkware
changed the base branch from
matan/consensus/milestone3/return_error_from_shc_decision
to
main
matan-starkware
changed the base branch from
main
to
matan/consensus/milestone3/return_error_from_shc_decision
asmaastarkware
approved these changes
Dec 26, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @matan-starkware)
matan-starkware
force-pushed
the
matan/consensus/milestone3/return_error_from_shc_decision
branch
from
4cfdc84 to
174b2f0
Compare
Merge activity |
matan-starkware
changed the base branch from
matan/consensus/milestone3/return_error_from_shc_decision
to
main
matan-starkware
force-pushed
the
matan/consensus/milestone3/await_build_proposal_task
branch
from
c0622f5 to
aa509fd
Compare
matan-starkware
force-pushed
the
matan/consensus/milestone3/await_build_proposal_task
branch
from
aa509fd to
9d8eec7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.