Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(consensus): update handle_state_machine_decision to return InternalInconsistency #2957

Merged
merged 1 commit into from
Dec 27, 2024
Merged

chore(consensus): update handle_state_machine_decision to return InternalInconsistency #2957

merged 1 commit into from
Dec 27, 2024

Conversation

matan-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@matan-starkware matan-starkware marked this pull request as ready for review December 25, 2024 13:07
@matan-starkware matan-starkware mentioned this pull request Dec 25, 2024
Merged
This was referenced Dec 25, 2024
Merged
Merged
@matan-starkware Graphite App
Copy link
Contributor Author

matan-starkware commented Dec 25, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@matan-starkware matan-starkware mentioned this pull request Dec 25, 2024
Merged
@matan-starkware matan-starkware force-pushed the matan/consensus/mileston3/add_internal_inconsistency_error branch from 14d8458 to a294352 Compare December 25, 2024 16:36
@matan-starkware matan-starkware force-pushed the matan/consensus/milestone3/return_error_from_shc_decision branch from 3ee72d1 to 4cfdc84 Compare December 25, 2024 16:37
asmaastarkware
asmaastarkware approved these changes Dec 26, 2024
View reviewed changes
Copy link
Contributor

@asmaastarkware asmaastarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @matan-starkware)

@matan-starkware matan-starkware force-pushed the matan/consensus/mileston3/add_internal_inconsistency_error branch from a294352 to ca566e7 Compare December 26, 2024 09:18
@matan-starkware matan-starkware force-pushed the matan/consensus/milestone3/return_error_from_shc_decision branch from 4cfdc84 to 174b2f0 Compare December 26, 2024 09:18
@matan-starkware matan-starkware force-pushed the matan/consensus/mileston3/add_internal_inconsistency_error branch 2 times, most recently from 55cdca7 to c36e273 Compare December 26, 2024 09:53
@matan-starkware matan-starkware force-pushed the matan/consensus/milestone3/return_error_from_shc_decision branch from 174b2f0 to 5d9028e Compare December 26, 2024 09:53
@matan-starkware matan-starkware force-pushed the matan/consensus/mileston3/add_internal_inconsistency_error branch from c36e273 to bc3f8f1 Compare December 26, 2024 10:21
@matan-starkware matan-starkware force-pushed the matan/consensus/milestone3/return_error_from_shc_decision branch from 5d9028e to 423de69 Compare December 26, 2024 10:21
@matan-starkware Graphite App
Copy link
Contributor Author

matan-starkware commented Dec 26, 2024 •
edited
Loading

Merge activity

  • Dec 26, 7:08 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 26, 7:29 AM EST: Graphite rebased this pull request as part of a merge.
  • Dec 26, 7:36 AM EST: Graphite couldn't add this PR to the GitHub merge queue because it was not satisfying all requirements (Failed CI: 'merge-gatekeeper', 'build-and-run-sequencer-integration-tests').
  • Dec 27, 2:47 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 27, 2:47 AM EST: A user added this pull request to the GitHub merge queue with Graphite.

@matan-starkware matan-starkware changed the base branch from matan/consensus/mileston3/add_internal_inconsistency_error to graphite-base/2957 December 26, 2024 12:08
@matan-starkware matan-starkware changed the base branch from graphite-base/2957 to main December 26, 2024 12:08
@matan-starkware matan-starkware force-pushed the matan/consensus/milestone3/return_error_from_shc_decision branch from 423de69 to d846b9b Compare December 26, 2024 12:28
@matan-starkware matan-starkware force-pushed the matan/consensus/milestone3/return_error_from_shc_decision branch from d846b9b to acaa2c5 Compare December 26, 2024 20:36
@matan-starkware matan-starkware added this pull request to the merge queue Dec 27, 2024
Merged via the queue into main with commit 989236a Dec 27, 2024
14 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@asmaastarkware asmaastarkware asmaastarkware approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matan-starkware @reviewable-StarkWare @asmaastarkware