Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(consensus): inline the function #2955

Merged
merged 2 commits into from
Dec 26, 2024
Merged

refactor(consensus): inline the function #2955

merged 2 commits into from
Dec 26, 2024

Conversation

matan-starkware
Copy link
Contributor

also includes some minor changes to the code.

@matan-starkware matan-starkware marked this pull request as ready for review December 25, 2024 12:51
@reviewable-StarkWare
Copy link

This change is Reviewable

@matan-starkware Graphite App
Copy link
Contributor Author

matan-starkware commented Dec 25, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@matan-starkware matan-starkware mentioned this pull request Dec 25, 2024
Merged
This was referenced Dec 25, 2024
Merged
Open
Open
@matan-starkware matan-starkware changed the base branch from matan/consensus/mileston3/check_reproposal_condition_before_getting_id to graphite-base/2955 December 25, 2024 16:35
@matan-starkware matan-starkware force-pushed the matan/consensus/mileston3/remove_process_inbound_proposal branch from 8786f07 to 684cf36 Compare December 25, 2024 16:35
@matan-starkware matan-starkware changed the base branch from graphite-base/2955 to main December 25, 2024 16:36
@matan-starkware matan-starkware force-pushed the matan/consensus/mileston3/remove_process_inbound_proposal branch from 684cf36 to abf55f7 Compare December 25, 2024 16:36
@matan-starkware matan-starkware force-pushed the matan/consensus/mileston3/remove_process_inbound_proposal branch from abf55f7 to e7f5281 Compare December 26, 2024 09:18
asmaastarkware
asmaastarkware approved these changes Dec 26, 2024
View reviewed changes
Copy link
Contributor

@asmaastarkware asmaastarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, 1 of 1 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @matan-starkware)

@matan-starkware Graphite App
Copy link
Contributor Author

matan-starkware commented Dec 26, 2024 •
edited
Loading

Merge activity

  • Dec 26, 4:52 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 26, 4:52 AM EST: A user added this pull request to the GitHub merge queue with Graphite.

@matan-starkware matan-starkware added this pull request to the merge queue Dec 26, 2024
Merged via the queue into main with commit 2248b50 Dec 26, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asmaastarkware asmaastarkware asmaastarkware approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matan-starkware @reviewable-StarkWare @asmaastarkware