feat(starknet_gateway): implement sync state reader get block info

[noamsp-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[noamsp-starkware]

• feat(starknet_gateway): implement sync state reader get block info #2942 : 2 dependent PRs (#2903 , #2944 ) 👈 (View in Graphite)
• fix(starknet_state_sync): verify contract deployed at get storage/nonce #2963 : 1 other dependent PR (#2886 )
• fix(starknet_state_sync): change marker verify from casm to state #2979
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[ShahakShama]

Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on @eitanm-starkware and @noamsp-starkware)

---

crates/starknet_gateway/src/sync_state_reader.rs line 53 at r4 (raw file):

                },
            },
            use_kzg_da: matches!(block_header.l1_da_mode, L1DataAvailabilityMode::Blob),

This will compile if someone adds a variant to L1DataAvailabilityMode, and I want it to not compile in that case so that the person who added a variant will TAL at this code and decide what's right

[ShahakShama]

Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on @eitanm-starkware and @noamsp-starkware)

---

crates/starknet_gateway/src/sync_state_reader.rs line 53 at r4 (raw file):

Previously, ShahakShama wrote…

This will compile if someone adds a variant to L1DataAvailabilityMode, and I want it to not compile in that case so that the person who added a variant will TAL at this code and decide what's right

Leaving unblocking so that if you fix it and Eitan approves you can merge

[noamsp-starkware]

Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on @eitanm-starkware and @ShahakShama)

---

crates/starknet_gateway/src/sync_state_reader.rs line 53 at r4 (raw file):

Previously, ShahakShama wrote…

Leaving unblocking so that if you fix it and Eitan approves you can merge

Fixed

[eitanm-starkware]

Reviewed 1 of 6 files at r4, 4 of 4 files at r5, all commit messages.
Reviewable status: 5 of 7 files reviewed, 1 unresolved discussion (waiting on @ShahakShama)

---

crates/starknet_gateway/src/sync_state_reader.rs line 34 at r5 (raw file):

        let block = block_on(self.state_sync_client.get_block(self.block_number))
            .map_err(|e| StateError::StateReadError(e.to_string()))?
            .ok_or(StateError::StateReadError("Block not found".to_string()))?;

ok_or_else isnt eager - better practice to use it when there is a fn calculated in the brackets. leaving unblocking

Suggestion:

ok_or_else(||

[noamsp-starkware]

Reviewable status: 4 of 7 files reviewed, all discussions resolved (waiting on @eitanm-starkware and @ShahakShama)

---

crates/starknet_gateway/src/sync_state_reader.rs line 34 at r5 (raw file):

Previously, eitanm-starkware wrote…

ok_or_else isnt eager - better practice to use it when there is a fn calculated in the brackets. leaving unblocking

Done

[ShahakShama]

Reviewed 1 of 1 files at r6, all commit messages.
Reviewable status: 5 of 7 files reviewed, all discussions resolved (waiting on @eitanm-starkware)

---

crates/starknet_gateway/src/sync_state_reader.rs line 34 at r5 (raw file):

Previously, noamsp-starkware wrote…

Done

No. It's actually better to do ok_or in this case. ok_or_else should only be used if the calculation is either heavy or it produces panic

[ShahakShama]

Reviewable status: 5 of 7 files reviewed, all discussions resolved (waiting on @eitanm-starkware)

---

crates/starknet_gateway/src/sync_state_reader.rs line 34 at r5 (raw file):

Previously, ShahakShama wrote…

No. It's actually better to do ok_or in this case. ok_or_else should only be used if the calculation is either heavy or it produces panic

Please revert

[ShahakShama]

Reviewed 1 of 1 files at r7, all commit messages.
Reviewable status: 5 of 7 files reviewed, all discussions resolved (waiting on @eitanm-starkware)

[ShahakShama]

Reviewed 2 of 6 files at r4.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noamsp-starkware)