-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(starknet_state_sync): verify contract deployed at get storage/nonce #2963
fix(starknet_state_sync): verify contract deployed at get storage/nonce #2963
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
87859c0
to
c2267ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ShahakShama)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @noamsp-starkware)
crates/starknet_state_sync/src/lib.rs
line 111 at r1 (raw file):
let state_number = StateNumber::unchecked_right_after_block(block_number); let state_reader = txn.get_state_reader()?;
add newline between creating the state reader and running the call to get_storage_at
crates/starknet_state_sync/src/lib.rs
line 113 at r1 (raw file):
let state_reader = txn.get_state_reader()?; let res = state_reader.get_storage_at(state_number, &contract_address, &storage_key)?; verify_contract_deployed(&state_reader, state_number, contract_address)?;
Move this before the call to get_storage_at
crates/starknet_state_sync/src/lib.rs
line 128 at r1 (raw file):
let state_number = StateNumber::unchecked_right_after_block(block_number); let state_reader = txn.get_state_reader()?; let res = state_reader
Same as above
crates/starknet_state_sync/src/lib.rs
line 131 at r1 (raw file):
.get_nonce_at(state_number, &contract_address)? .ok_or(StateSyncError::ContractNotFound(contract_address))?; verify_contract_deployed(&state_reader, state_number, contract_address)?;
Same as above
c2267ac
to
367bc61
Compare
Artifacts upload workflows: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noamsp-starkware)
No description provided.