feat(starknet_state_sync): implement sync state reader get block info

[noamsp-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[noamsp-starkware]

• feat(starknet_state_sync): implement sync state reader get block info #2887 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[ShahakShama]

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @noamsp-starkware)

---

crates/starknet_state_sync/src/lib.rs line 200 at r1 (raw file):

    }

    fn get_block_header(&self, block_number: BlockNumber) -> StateSyncResult<BlockHeader> {

Change this to get_block_info and have it return the block info extracted from the header

---

crates/starknet_state_sync/src/lib.rs line 203 at r1 (raw file):

        let txn = self.storage_reader.begin_ro_txn()?;
        let latest_block_number = txn.get_header_marker()?.prev();
        if latest_block_number.is_none_or(|latest_block_number| latest_block_number < block_number)

No need for this check. You can just straight up call get_block_header and it will return None if latest_block_number < block_number

---

crates/starknet_gateway/src/sync_state_reader.rs line 42 at r1 (raw file):

            sequencer_address: block_header_without_hash.sequencer.0,
            block_timestamp: block_header_without_hash.timestamp,
            gas_prices: validated_gas_prices(

What's validated_gas_prices and parse_gas_prices? Could you point me to the code where you've seen this used?

[noamsp-starkware]

Reviewable status: 0 of 5 files reviewed, 3 unresolved discussions (waiting on @ShahakShama)

---

crates/starknet_gateway/src/sync_state_reader.rs line 42 at r1 (raw file):

Previously, ShahakShama wrote…

What's validated_gas_prices and parse_gas_prices? Could you point me to the code where you've seen this used?

sequencer/crates/starknet_gateway/src/rpc_objects.rs

Code snippet:

impl TryInto<BlockInfo> for BlockHeader {
    type Error = RPCStateReaderError;
    fn try_into(self) -> Result<BlockInfo, Self::Error> {
        Ok(BlockInfo {
            block_number: self.block_number,
            sequencer_address: self.sequencer_address,
            block_timestamp: self.timestamp,
            gas_prices: validated_gas_prices(
                parse_gas_price(self.l1_gas_price.price_in_wei)?,
                parse_gas_price(self.l1_gas_price.price_in_fri)?,
                parse_gas_price(self.l1_data_gas_price.price_in_wei)?,
                parse_gas_price(self.l1_data_gas_price.price_in_fri)?,
                parse_gas_price(self.l2_gas_price.price_in_wei)?,
                parse_gas_price(self.l2_gas_price.price_in_fri)?,
            ),
            use_kzg_da: matches!(self.l1_da_mode, L1DataAvailabilityMode::Blob),
        })
    }
}

---

crates/starknet_state_sync/src/lib.rs line 200 at r1 (raw file):

Previously, ShahakShama wrote…

Change this to get_block_info and have it return the block info extracted from the header

Done.

---

crates/starknet_state_sync/src/lib.rs line 203 at r1 (raw file):

Previously, ShahakShama wrote…

No need for this check. You can just straight up call get_block_header and it will return None if latest_block_number < block_number

Done.

[github-actions]

Artifacts upload workflows:

• Started at 2024-12-23T18:55:41Z

[eitanm-starkware]

Reviewed 5 of 5 files at r2, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @noamsp-starkware and @ShahakShama)

---

crates/starknet_gateway/src/sync_state_reader.rs line 37 at r2 (raw file):

            Some(block_info) => block_info,
            None => return Err(StateError::StateReadError("Block info not found".to_string())),
        };

Suggestion:

        maybe_block_info.ok_or_else(...)
        let block_info = match maybe_block_info {
            Some(block_info) => block_info,
            None => return Err(StateError::StateReadError("Block info not found".to_string())),
        };

---

crates/starknet_state_sync/src/lib.rs line 206 at r2 (raw file):

        let txn = self.storage_reader.begin_ro_txn()?;

        if let Some(block_header) = txn.get_block_header(block_number)? {

reduce nesting

Suggestion:

        let Some(block_header) = txn.get_block_header(block_number)? else { return None
        if let Some(block_header) = txn.get_block_header(block_number)? {

[ShahakShama]

Reviewed all commit messages.
Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @noamsp-starkware)

---

crates/starknet_state_sync/src/lib.rs line 203 at r2 (raw file):

    }

    fn get_block_info(&self, block_number: BlockNumber) -> StateSyncResult<Option<BlockInfo>> {

Now that Eitan added block info to get_block, we can erase this method and use get_block in SyncStateReader

[noamsp-starkware]

Closing this due to big changes that require a different approach. opened the respective fixed PR at #2942