chore(starknet_monitoring_endpoint): add metric test utils #2884
Conversation
|
This change is |
|
Artifacts upload workflows: |
Itay-Tsabary-Starkware
force-pushed
the
spr/main/523a1d3e
branch
from
04b609c to
478eed2
Compare
Itay-Tsabary-Starkware
force-pushed
the
spr/main/e1f0b265
branch
from
8e41067 to
b8446e9
Compare
Itay-Tsabary-Starkware
force-pushed
the
spr/main/523a1d3e
branch
from
478eed2 to
fd45754
Compare
Itay-Tsabary-Starkware
force-pushed
the
spr/main/e1f0b265
branch
from
b8446e9 to
fa49151
Compare
|
Benchmark movements: |
Itay-Tsabary-Starkware
force-pushed
the
spr/main/523a1d3e
branch
from
fd45754 to
e2cda4a
Compare
There was a problem hiding this comment.
Reviewed 2 of 3 files at r1, all commit messages.
Reviewable status: 2 of 3 files reviewed, 3 unresolved discussions (waiting on @Itay-Tsabary-Starkware)
crates/starknet_monitoring_endpoint/src/test_utils.rs line 87 at r1 (raw file):
// Parse the response body. let body_bytes = hyper::body::to_bytes(response.into_body()).await.unwrap();
Import hyper::body::to_bytes
Code quote:
hyper::body::to_bytescrates/starknet_monitoring_endpoint/src/test_utils.rs line 88 at r1 (raw file):
// Parse the response body. let body_bytes = hyper::body::to_bytes(response.into_body()).await.unwrap(); let body_string = String::from_utf8(body_bytes.to_vec()).unwrap();
Same
Code quote:
String::from_utf8crates/starknet_monitoring_endpoint/src/test_utils.rs line 96 at r1 (raw file):
} pub(crate) fn build_request(ip: &IpAddr, port: u16, method: &str) -> Request<Body> {
Please add TODO to pass the socket as an arg instead.
Code quote:
ip: &IpAddr, port: u16There was a problem hiding this comment.
Reviewable status: 2 of 3 files reviewed, 3 unresolved discussions (waiting on @nadin-Starkware)
crates/starknet_monitoring_endpoint/src/test_utils.rs line 87 at r1 (raw file):
Previously, nadin-Starkware (Nadin Jbara) wrote…
Import hyper::body::to_bytes
Done.
crates/starknet_monitoring_endpoint/src/test_utils.rs line 88 at r1 (raw file):
Previously, nadin-Starkware (Nadin Jbara) wrote…
Same
Doesn't apply here, it's a class function of A (like calling A::new()), it's not a function from a module String.
crates/starknet_monitoring_endpoint/src/test_utils.rs line 96 at r1 (raw file):
Previously, nadin-Starkware (Nadin Jbara) wrote…
Please add TODO to pass the socket as an arg instead.
Done.
Itay-Tsabary-Starkware
force-pushed
the
spr/main/e1f0b265
branch
from
3b8b0ea to
be0debb
Compare
Itay-Tsabary-Starkware
force-pushed
the
spr/main/523a1d3e
branch
from
e2cda4a to
7d2cfda
Compare
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)
There was a problem hiding this comment.
Reviewed 2 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:
Itay-Tsabary-Starkware
force-pushed
the
spr/main/523a1d3e
branch
from
7d2cfda to
461cf28
Compare
Itay-Tsabary-Starkware
force-pushed
the
spr/main/e1f0b265
branch
from
be0debb to
3c55a70
Compare
Itay-Tsabary-Starkware
changed the base branch from
spr/main/e1f0b265
to
main
Itay-Tsabary-Starkware
force-pushed
the
spr/main/523a1d3e
branch
from
461cf28 to
70be6f8
Compare
Itay-Tsabary-Starkware
changed the base branch from
main
to
spr/main/e1f0b265
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:
Itay-Tsabary-Starkware
changed the base branch from
spr/main/e1f0b265
to
main
commit-id:523a1d3e
Itay-Tsabary-Starkware
force-pushed
the
spr/main/523a1d3e
branch
from
70be6f8 to
fc0dd06
Compare
Stack: