Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(infra_utils): add parse_numeric_metric #2881

Merged
merged 1 commit into from
Dec 24, 2024
Merged

chore(infra_utils): add parse_numeric_metric #2881

merged 1 commit into from
Dec 24, 2024

Conversation

Itay-Tsabary-Starkware
Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware commented Dec 22, 2024 •
edited
Loading

This was referenced Dec 22, 2024
Open
Open
Open
@reviewable-StarkWare
Copy link

This change is Reviewable

This was referenced Dec 22, 2024
Merged
Open
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 22, 2024 •
edited
Loading

Artifacts upload workflows:

@github-actions GitHub Actions
Copy link

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [34.410 ms 34.729 ms 35.093 ms]
change: [+1.2530% +2.2262% +3.2201%] (p = 0.00 < 0.05)
Performance has regressed.
Found 19 outliers among 100 measurements (19.00%)
4 (4.00%) high mild
15 (15.00%) high severe

@github-actions GitHub Actions
Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [33.992 ms 34.024 ms 34.058 ms]
change: [-3.9483% -2.5080% -1.2471%] (p = 0.00 < 0.05)
Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
3 (3.00%) high mild
1 (1.00%) high severe

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware mentioned this pull request Dec 23, 2024
Open
nadin-Starkware
nadin-Starkware approved these changes Dec 23, 2024
View reviewed changes
Copy link
Collaborator

@nadin-Starkware nadin-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

@github-actions GitHub Actions
Copy link

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [34.593 ms 34.969 ms 35.394 ms]
change: [+1.8600% +2.9971% +4.3025%] (p = 0.00 < 0.05)
Performance has regressed.
Found 21 outliers among 100 measurements (21.00%)
7 (7.00%) high mild
14 (14.00%) high severe

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware changed the base branch from spr/main/9bf71741 to main December 24, 2024 07:57
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware changed the base branch from main to spr/main/def681cc December 24, 2024 10:17
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware mentioned this pull request Dec 24, 2024
Merged
nadin-Starkware
nadin-Starkware approved these changes Dec 24, 2024
View reviewed changes
Copy link
Collaborator

@nadin-Starkware nadin-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

Itay-Tsabary-Starkware
Itay-Tsabary-Starkware commented Dec 24, 2024
View reviewed changes
Copy link
Contributor Author

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware merged commit a99ca46 into spr/main/def681cc Dec 24, 2024
20 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nadin-Starkware nadin-Starkware nadin-Starkware approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Itay-Tsabary-Starkware @reviewable-StarkWare @nadin-Starkware