chore(starknet_http_server): add metrics for added txs

[Itay-Tsabary-Starkware]

Stack:

• wip with http server / gateway bug #2888
• chore(starknet_http_server): add metrics tests, still partial #2885
• chore(starknet_monitoring_endpoint): add metric test utils #2884
• chore(infra_utils): add parse_numeric_metric #2881
• chore(starknet_http_server): add metrics for added txs #2744 ⬅

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

[reviewable-StarkWare]

This change is 

[github-actions]

Artifacts upload workflows:

• Started at 2024-12-18T06:25:45Z
• Started at 2024-12-18T09:38:25Z
• Started at 2024-12-18T09:38:25Z
• Started at 2024-12-20T19:34:04Z
• Started at 2024-12-22T17:35:34Z
• Started at 2024-12-22T18:39:52Z
• Started at 2024-12-22T20:59:14Z
• Started at 2024-12-23T07:16:17Z
• Started at 2024-12-23T09:30:39Z
• Started at 2024-12-23T12:37:06Z

[nadin-Starkware]

Reviewed 4 of 5 files at r1, all commit messages.
Reviewable status: 4 of 5 files reviewed, 3 unresolved discussions (waiting on @Itay-Tsabary-Starkware)

---

crates/starknet_http_server/src/metrics.rs line 10 at r1 (raw file):

    ("ADDED_TRANSACTIONS_FAILURE", "Number of faulty added transactions", 0);

pub(crate) fn init_metrics() {

Please add a log message to indicate that the metric has been initialized

Code quote:

pub(crate) fn init_metrics() {

---

crates/starknet_http_server/src/metrics.rs line 24 at r1 (raw file):

}

pub(crate) fn count_added_transaction() {

Consider renaming to increment_total_transactions

Code quote:

count_added_transaction

---

crates/starknet_http_server/src/metrics.rs line 28 at r1 (raw file):

}

pub(crate) fn count_transaction_status(add_tx_success: bool) {

Consider renaming the function to record_transaction_status

Code quote:

 count_transaction_status

[Itay-Tsabary-Starkware]

Reviewable status: 4 of 5 files reviewed, 1 unresolved discussion (waiting on @nadin-Starkware)

---

crates/starknet_http_server/src/metrics.rs line 10 at r1 (raw file):

Previously, nadin-Starkware (Nadin Jbara) wrote…

Please add a log message to indicate that the metric has been initialized

Done.

[nadin-Starkware]

Reviewed 1 of 5 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)