test(starknet_api): use const for l1 handler tx version

[ArniStarkware]

No description provided.

[reviewable-StarkWare]

This change is 

[github-actions]

Artifacts upload workflows:

• Started at 2024-12-18T13:45:19Z
• Started at 2024-12-19T12:22:18Z

[ArniStarkware]

• chore(starknet_api): create a new method for l1 handler using version 0 #2702
• test(starknet_api): remove the version argument from l1 handler tx args #2699
• test(starknet_api): set l1 handler tx version to default zero #2698
• test(starknet_api): use const for l1 handler tx version #2763 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[giladchase]

Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on @ArniStarkware)

---

crates/starknet_api/src/transaction.rs line 692 at r2 (raw file):

    /// purposes.
    pub const VERSION: TransactionVersion = TransactionVersion::ZERO;
}

WDYT?
This will
a) make its api consistent with the rest of the tx types which all use a getter
b) make it impossible to instantiate an l1 tx with an incorrect field (and communicate that fact better maybe)

Suggestion:

#[derive(Debug, Clone, Default, Eq, PartialEq, Hash, Deserialize, Serialize, PartialOrd, Ord)]
pub struct L1HandlerTransaction {
    pub nonce: Nonce,
    pub contract_address: ContractAddress,
    pub entry_point_selector: EntryPointSelector,
    pub calldata: Calldata,
}

impl L1HandlerTransaction {
    /// The transaction version is considered 0 for L1-Handler transaction for hash calculation
    /// purposes.
    pub const VERSION: TransactionVersion = TransactionVersion::ZERO;
    
    pub fn version(&self) -> TransactionVersion {
        Self::VERSION
    }
}

[ArniStarkware]

Reviewable status: 0 of 7 files reviewed, all discussions resolved (waiting on @giladchase)

---

crates/starknet_api/src/transaction.rs line 692 at r2 (raw file):

Previously, giladchase wrote…

WDYT?
This will
a) make its api consistent with the rest of the tx types which all use a getter
b) make it impossible to instantiate an l1 tx with an incorrect field (and communicate that fact better maybe)

On a later PR.

I tried something similar. There is an issue with the serialization, etc.

[giladchase]

Reviewed 7 of 7 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)

---

crates/starknet_api/src/transaction.rs line 692 at r2 (raw file):

Previously, ArniStarkware (Arnon Hod) wrote…

On a later PR.

I tried something similar. There is an issue with the serialization, etc.

🫠

[ArniStarkware]

Merge activity

• Dec 22, 3:39 AM EST: A user started a stack merge that includes this pull request via Graphite.
• Dec 22, 3:39 AM EST: A user merged this pull request with Graphite.