Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(starknet_api): remove the version argument from l1 handler tx args #2699

Conversation

ArniStarkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@ArniStarkware ArniStarkware force-pushed the arni/l1_handler/test_utils/remove_redundent_version_argument branch from 64e1cb0 to 04138b7 Compare December 16, 2024 14:00
@ArniStarkware ArniStarkware force-pushed the arni/l1_handler/test_util/version/align_to_version_0 branch from 7e41e5e to 382637c Compare December 16, 2024 15:51
@ArniStarkware ArniStarkware force-pushed the arni/l1_handler/test_utils/remove_redundent_version_argument branch from 04138b7 to df835d3 Compare December 16, 2024 15:51
Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [34.718 ms 34.758 ms 34.801 ms]
change: [-3.8599% -2.3599% -1.0338%] (p = 0.00 < 0.05)
Performance has improved.
Found 8 outliers among 100 measurements (8.00%)
3 (3.00%) low mild
4 (4.00%) high mild
1 (1.00%) high severe

@ArniStarkware ArniStarkware force-pushed the arni/l1_handler/test_util/version/align_to_version_0 branch from 382637c to 1b6b7c2 Compare December 17, 2024 09:08
@ArniStarkware ArniStarkware force-pushed the arni/l1_handler/test_utils/remove_redundent_version_argument branch from df835d3 to 033da3a Compare December 17, 2024 09:08
Copy link

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [35.530 ms 35.954 ms 36.477 ms]
change: [+1.5098% +2.6556% +4.0807%] (p = 0.00 < 0.05)
Performance has regressed.
Found 14 outliers among 100 measurements (14.00%)
7 (7.00%) high mild
7 (7.00%) high severe

@ArniStarkware ArniStarkware force-pushed the arni/l1_handler/test_util/version/align_to_version_0 branch from 1b6b7c2 to 876b13a Compare December 17, 2024 09:32
@ArniStarkware ArniStarkware force-pushed the arni/l1_handler/test_utils/remove_redundent_version_argument branch from 033da3a to 0d8bd77 Compare December 17, 2024 09:32
@ArniStarkware ArniStarkware force-pushed the arni/l1_handler/test_util/version/align_to_version_0 branch from 876b13a to 39026c3 Compare December 18, 2024 13:45
@ArniStarkware ArniStarkware force-pushed the arni/l1_handler/test_utils/remove_redundent_version_argument branch from 0d8bd77 to 514d14d Compare December 18, 2024 13:45
@ArniStarkware ArniStarkware force-pushed the arni/l1_handler/test_util/version/align_to_version_0 branch from 39026c3 to e41a553 Compare December 19, 2024 12:22
@ArniStarkware ArniStarkware force-pushed the arni/l1_handler/test_utils/remove_redundent_version_argument branch from 514d14d to db5e7bd Compare December 19, 2024 12:22
Copy link
Contributor

@giladchase giladchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)


crates/starknet_api/src/test_utils/l1_handler.rs line 29 at r2 (raw file):

        }
    }
}

🔥

Code quote:

impl Default for L1HandlerTxArgs {
    fn default() -> Self {
        L1HandlerTxArgs {
            version: L1HandlerTransaction::VERSION,
            nonce: Nonce::default(),
            contract_address: ContractAddress::default(),
            entry_point_selector: EntryPointSelector::default(),
            calldata: Calldata::default(),
            tx_hash: TransactionHash::default(),
            paid_fee_on_l1: Fee::default(),
        }
    }
}

Copy link
Contributor Author

ArniStarkware commented Dec 22, 2024

Merge activity

  • Dec 22, 3:39 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 22, 4:03 AM EST: Graphite rebased this pull request as part of a merge.
  • Dec 22, 4:23 AM EST: A user merged this pull request with Graphite.

@ArniStarkware ArniStarkware changed the base branch from arni/l1_handler/test_util/version/align_to_version_0 to graphite-base/2699 December 22, 2024 08:40
Copy link

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [34.759 ms 35.100 ms 35.479 ms]
change: [+1.3862% +2.3499% +3.4398%] (p = 0.00 < 0.05)
Performance has regressed.
Found 21 outliers among 100 measurements (21.00%)
6 (6.00%) high mild
15 (15.00%) high severe

@ArniStarkware ArniStarkware changed the base branch from graphite-base/2699 to main December 22, 2024 09:01
@ArniStarkware ArniStarkware force-pushed the arni/l1_handler/test_utils/remove_redundent_version_argument branch from db5e7bd to 0f9d999 Compare December 22, 2024 09:02
@ArniStarkware ArniStarkware merged commit 2aea31d into main Dec 22, 2024
14 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants