-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(starknet_api): remove the version argument from l1 handler tx args #2699
test(starknet_api): remove the version argument from l1 handler tx args #2699
Conversation
Artifacts upload workflows: |
64e1cb0
to
04138b7
Compare
7e41e5e
to
382637c
Compare
04138b7
to
df835d3
Compare
Benchmark movements: |
382637c
to
1b6b7c2
Compare
df835d3
to
033da3a
Compare
Benchmark movements: |
1b6b7c2
to
876b13a
Compare
033da3a
to
0d8bd77
Compare
876b13a
to
39026c3
Compare
0d8bd77
to
514d14d
Compare
39026c3
to
e41a553
Compare
514d14d
to
db5e7bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)
crates/starknet_api/src/test_utils/l1_handler.rs
line 29 at r2 (raw file):
} } }
🔥
Code quote:
impl Default for L1HandlerTxArgs {
fn default() -> Self {
L1HandlerTxArgs {
version: L1HandlerTransaction::VERSION,
nonce: Nonce::default(),
contract_address: ContractAddress::default(),
entry_point_selector: EntryPointSelector::default(),
calldata: Calldata::default(),
tx_hash: TransactionHash::default(),
paid_fee_on_l1: Fee::default(),
}
}
}
Benchmark movements: |
db5e7bd
to
0f9d999
Compare
No description provided.