Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(starknet_api): set l1 handler tx version to default zero #2698

Merged

Conversation

ArniStarkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@ArniStarkware ArniStarkware marked this pull request as ready for review December 16, 2024 13:36
Copy link

github-actions bot commented Dec 17, 2024

@ArniStarkware ArniStarkware force-pushed the arni/l1_handler/test_util/version/align_to_version_0 branch from 1b6b7c2 to 876b13a Compare December 17, 2024 09:32
Copy link
Contributor Author

@ArniStarkware ArniStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 9 files reviewed, all discussions resolved


crates/starknet_api/src/test_utils/l1_handler.rs line 20 at r2 (raw file):

    fn default() -> Self {
        L1HandlerTxArgs {
            version: TransactionVersion::THREE,

This number has changed in this PR.

Code quote:

TransactionVersion::THREE,

crates/papyrus_rpc/src/v0_8/transaction.rs line 1284 at r2 (raw file):

        let calldata = Calldata(Arc::new(calldata));
        Self {
            version: TransactionVersion::ONE,

This number has changed in this PR.

Code quote:

version: TransactionVersion::ONE,

@ArniStarkware ArniStarkware force-pushed the arni/l1_handler/test_util/version/align_to_version_0 branch from 876b13a to 39026c3 Compare December 18, 2024 13:45
@ArniStarkware ArniStarkware changed the base branch from main to arni/l1_handler/test_utils/version/use_const December 18, 2024 13:45
@ArniStarkware ArniStarkware force-pushed the arni/l1_handler/test_utils/version/use_const branch from 8fbc491 to 3437855 Compare December 19, 2024 12:22
@ArniStarkware ArniStarkware force-pushed the arni/l1_handler/test_util/version/align_to_version_0 branch from 39026c3 to e41a553 Compare December 19, 2024 12:22
Copy link
Contributor

@giladchase giladchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 9 of 9 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)

Copy link
Contributor Author

ArniStarkware commented Dec 22, 2024

Merge activity

  • Dec 22, 3:39 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 22, 3:41 AM EST: Graphite rebased this pull request as part of a merge.
  • Dec 22, 4:01 AM EST: A user merged this pull request with Graphite.

@ArniStarkware ArniStarkware changed the base branch from arni/l1_handler/test_utils/version/use_const to graphite-base/2698 December 22, 2024 08:39
@ArniStarkware ArniStarkware changed the base branch from graphite-base/2698 to main December 22, 2024 08:39
@ArniStarkware ArniStarkware force-pushed the arni/l1_handler/test_util/version/align_to_version_0 branch from e41a553 to 85995b2 Compare December 22, 2024 08:40
@ArniStarkware ArniStarkware merged commit 5b2438e into main Dec 22, 2024
18 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants