-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(starknet_api): set l1 handler tx version to default zero #2698
test(starknet_api): set l1 handler tx version to default zero #2698
Conversation
382637c
to
1b6b7c2
Compare
Artifacts upload workflows: |
1b6b7c2
to
876b13a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 9 files reviewed, all discussions resolved
crates/starknet_api/src/test_utils/l1_handler.rs
line 20 at r2 (raw file):
fn default() -> Self { L1HandlerTxArgs { version: TransactionVersion::THREE,
This number has changed in this PR.
Code quote:
TransactionVersion::THREE,
crates/papyrus_rpc/src/v0_8/transaction.rs
line 1284 at r2 (raw file):
let calldata = Calldata(Arc::new(calldata)); Self { version: TransactionVersion::ONE,
This number has changed in this PR.
Code quote:
version: TransactionVersion::ONE,
876b13a
to
39026c3
Compare
8fbc491
to
3437855
Compare
39026c3
to
e41a553
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 9 of 9 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)
e41a553
to
85995b2
Compare
No description provided.