Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sequencing): make repropose use the proper channel #2532

Conversation

guy-starkware
Copy link
Contributor

@guy-starkware guy-starkware commented Dec 8, 2024

In papyrus consensus context, I replaced the old repropose function with a new version that uses the correct proposal channel to send the proposal.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Project coverage is 17.67%. Comparing base (8a23f86) to head (6dfb1bb).

Files with missing lines Patch % Lines
...nsus_orchestrator/src/papyrus_consensus_context.rs 0.00% 19 Missing ⚠️
Additional details and impacted files
@@                            Coverage Diff                             @@
##           guyn/streams/remove_consensus_message3    #2532      +/-   ##
==========================================================================
+ Coverage                                    9.59%   17.67%   +8.07%     
==========================================================================
  Files                                          87      122      +35     
  Lines                                       10481    14112    +3631     
  Branches                                    10481    14112    +3631     
==========================================================================
+ Hits                                         1006     2494    +1488     
- Misses                                       9442    11351    +1909     
- Partials                                       33      267     +234     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message3 branch from 27483e5 to 6e1aa30 Compare December 9, 2024 13:23
@guy-starkware guy-starkware force-pushed the guyn/streams/repropose_fix branch from a387c0e to 8d2e266 Compare December 9, 2024 13:23
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message3 branch from 6e1aa30 to 48ddeba Compare December 10, 2024 07:31
@guy-starkware guy-starkware force-pushed the guyn/streams/repropose_fix branch from 8d2e266 to 434b5ac Compare December 10, 2024 07:31
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message3 branch from 48ddeba to 683ff84 Compare December 10, 2024 07:41
@guy-starkware guy-starkware force-pushed the guyn/streams/repropose_fix branch from 434b5ac to 946474c Compare December 10, 2024 07:41
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message3 branch from 683ff84 to 463c0cc Compare December 10, 2024 08:11
@guy-starkware guy-starkware force-pushed the guyn/streams/repropose_fix branch from 946474c to ced6686 Compare December 10, 2024 08:11
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message3 branch 2 times, most recently from e6d6c5f to 088e03c Compare December 10, 2024 08:26
@guy-starkware guy-starkware force-pushed the guyn/streams/repropose_fix branch from ced6686 to adefee5 Compare December 10, 2024 08:26
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message3 branch from 088e03c to 02e5a04 Compare December 10, 2024 09:53
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message3 branch from bb97c32 to 45fa6d6 Compare December 10, 2024 17:01
@guy-starkware guy-starkware force-pushed the guyn/streams/repropose_fix branch from 281a04c to 26d3496 Compare December 10, 2024 17:02
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message3 branch from 45fa6d6 to 8430e7a Compare December 11, 2024 16:52
@guy-starkware guy-starkware force-pushed the guyn/streams/repropose_fix branch from 26d3496 to bb5c0a3 Compare December 11, 2024 16:52
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message3 branch from 8430e7a to 8a23f86 Compare December 11, 2024 19:31
@guy-starkware guy-starkware force-pushed the guyn/streams/repropose_fix branch from bb5c0a3 to 6dfb1bb Compare December 11, 2024 19:31
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message3 branch from 8a23f86 to 41666b3 Compare December 15, 2024 11:06
@guy-starkware guy-starkware force-pushed the guyn/streams/repropose_fix branch from 6dfb1bb to 8ebd640 Compare December 15, 2024 11:06
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message3 branch 2 times, most recently from 43790e2 to e9ddee2 Compare December 19, 2024 19:10
@guy-starkware guy-starkware force-pushed the guyn/streams/repropose_fix branch from 8ebd640 to d32e83f Compare December 19, 2024 19:10
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message3 branch from e9ddee2 to 3d95cba Compare December 19, 2024 20:45
@guy-starkware guy-starkware force-pushed the guyn/streams/repropose_fix branch from d32e83f to 56d65d6 Compare December 19, 2024 20:45
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message3 branch from 3d95cba to 84990f2 Compare December 19, 2024 20:57
@guy-starkware guy-starkware force-pushed the guyn/streams/repropose_fix branch from 56d65d6 to 1ac9457 Compare December 19, 2024 20:57
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message3 branch from 84990f2 to 714c537 Compare December 20, 2024 06:46
@guy-starkware guy-starkware force-pushed the guyn/streams/repropose_fix branch from 1ac9457 to 3468575 Compare December 20, 2024 06:47
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message3 branch from 714c537 to fe5bc0e Compare December 20, 2024 07:07
@guy-starkware guy-starkware force-pushed the guyn/streams/repropose_fix branch from 3468575 to 5612784 Compare December 20, 2024 07:08
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message3 branch 2 times, most recently from e25d90d to 2311ec9 Compare December 20, 2024 07:31
@guy-starkware guy-starkware force-pushed the guyn/streams/repropose_fix branch from 5612784 to 1c19584 Compare December 20, 2024 07:31
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message3 branch from 2311ec9 to 9a997c0 Compare December 22, 2024 10:11
@guy-starkware guy-starkware force-pushed the guyn/streams/repropose_fix branch from 1c19584 to 114801f Compare December 22, 2024 10:11
@guy-starkware guy-starkware force-pushed the guyn/streams/remove_consensus_message3 branch 2 times, most recently from 8fd221a to 28f0abb Compare December 22, 2024 12:43
@guy-starkware guy-starkware force-pushed the guyn/streams/repropose_fix branch from 114801f to 28f0abb Compare December 22, 2024 12:44
@github-actions github-actions bot locked and limited conversation to collaborators Dec 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants