chore(sequencing): remove ConsensusMessage from converter test #2525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This was referenced Dec 8, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## guyn/streams/remove_mock_context #2525 +/- ##
===================================================================
Coverage ? 36.04%
===================================================================
Files ? 51
Lines ? 6309
Branches ? 6309
===================================================================
Hits ? 2274
Misses ? 3734
Partials ? 301 ☔ View full report in Codecov by Sentry. |
guy-starkware
changed the title
guy-starkware
force-pushed
the
guyn/streams/remove_consensus_message
branch
from
cb9941d to
0afc2fc
Compare
guy-starkware
changed the title
This was referenced Dec 8, 2024
guy-starkware
force-pushed
the
guyn/streams/remove_mock_context
branch
from
98fba66 to
786dfe2
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_consensus_message
branch
from
0afc2fc to
40b4049
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_mock_context
branch
from
786dfe2 to
3e94c68
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_consensus_message
branch
from
40b4049 to
33109ec
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_mock_context
branch
from
3e94c68 to
8b53dad
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_consensus_message
branch
from
33109ec to
588e000
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_mock_context
branch
from
8b53dad to
22f54b1
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_consensus_message
branch
from
588e000 to
7527dcc
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_mock_context
branch
from
22f54b1 to
392ca7c
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_consensus_message
branch
from
7527dcc to
1c51cfc
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_mock_context
branch
from
392ca7c to
5873234
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_consensus_message
branch
from
cc50c7b to
8f057b2
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_mock_context
branch
2 times, most recently
from
336697d to
6d5e7bd
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_consensus_message
branch
from
8f057b2 to
27b67fe
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_mock_context
branch
from
6d5e7bd to
6a92643
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_consensus_message
branch
from
27b67fe to
3614fe5
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_mock_context
branch
from
6a92643 to
4a0bbd7
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_consensus_message
branch
from
3614fe5 to
93f13e3
Compare
asmaastarkware
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @matan-starkware)
matan-starkware
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:
guy-starkware
force-pushed
the
guyn/streams/remove_mock_context
branch
from
4a0bbd7 to
385f3a6
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_consensus_message
branch
from
93f13e3 to
f19523d
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_mock_context
branch
from
385f3a6 to
2719018
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_consensus_message
branch
from
f19523d to
426005a
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_mock_context
branch
from
2719018 to
33813b5
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_consensus_message
branch
from
426005a to
a486758
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_mock_context
branch
from
33813b5 to
cbf0835
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_consensus_message
branch
from
a486758 to
5fad1ad
Compare
guy-starkware
commented
Dec 20, 2024
There was a problem hiding this comment.
Reviewed 2 of 4 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status:
guy-starkware
changed the base branch from
guyn/streams/remove_mock_context
to
graphite-base/2525
guy-starkware
force-pushed
the
graphite-base/2525
branch
from
cbf0835 to
c3325e5
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_consensus_message
branch
from
5fad1ad to
597e3b3
Compare
guy-starkware
force-pushed
the
guyn/streams/remove_consensus_message
branch
from
597e3b3 to
81413ec
Compare
Merge activity
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm starting to remove the ConsensusMessage from where ever I can find it. It will come out in pieces. When done, I'll make another PR to remove it from the proto.