Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sequencing): add specific print message for wrong tx type #2518

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

guy-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@guy-starkware guy-starkware marked this pull request as ready for review December 8, 2024 10:15
Copy link

codecov bot commented Dec 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 46.56%. Comparing base (e3165c4) to head (6a806b0).
Report is 817 commits behind head on main.

Files with missing lines Patch % Lines
crates/starknet_api/src/transaction.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2518      +/-   ##
==========================================
+ Coverage   40.10%   46.56%   +6.45%     
==========================================
  Files          26       32       +6     
  Lines        1895     2968    +1073     
  Branches     1895     2968    +1073     
==========================================
+ Hits          760     1382     +622     
- Misses       1100     1520     +420     
- Partials       35       66      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 9, 2024

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [34.900 ms 35.348 ms 35.892 ms]
change: [+1.7356% +2.9969% +4.6653%] (p = 0.00 < 0.05)
Performance has regressed.
Found 7 outliers among 100 measurements (7.00%)
2 (2.00%) high mild
5 (5.00%) high severe

Copy link
Contributor

@asmaastarkware asmaastarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @matan-starkware)

@guy-starkware guy-starkware force-pushed the guyn/streams/hash_map_type branch from 31afe42 to ea76fac Compare December 10, 2024 07:31
@guy-starkware guy-starkware force-pushed the guyn/streams/print_bad_tx branch from c2f07b7 to 8364862 Compare December 10, 2024 07:31
@guy-starkware guy-starkware force-pushed the guyn/streams/hash_map_type branch from ea76fac to 379fbbb Compare December 10, 2024 07:41
@guy-starkware guy-starkware force-pushed the guyn/streams/print_bad_tx branch from 8364862 to 2b8cf29 Compare December 10, 2024 07:41
@guy-starkware guy-starkware force-pushed the guyn/streams/hash_map_type branch from 379fbbb to 0c88ba4 Compare December 10, 2024 08:11
@guy-starkware guy-starkware force-pushed the guyn/streams/print_bad_tx branch from 2b8cf29 to dcfa88f Compare December 10, 2024 08:11
@guy-starkware guy-starkware force-pushed the guyn/streams/hash_map_type branch from 0c88ba4 to 3e48a5f Compare December 10, 2024 08:24
@guy-starkware guy-starkware force-pushed the guyn/streams/print_bad_tx branch from dcfa88f to 7afd08a Compare December 10, 2024 08:24
@guy-starkware guy-starkware force-pushed the guyn/streams/hash_map_type branch from 3e48a5f to c9b269b Compare December 10, 2024 08:25
@guy-starkware guy-starkware force-pushed the guyn/streams/print_bad_tx branch from 7afd08a to 852e9f3 Compare December 10, 2024 08:25
@guy-starkware guy-starkware force-pushed the guyn/streams/hash_map_type branch from c9b269b to 92b40d1 Compare December 10, 2024 09:53
@guy-starkware guy-starkware force-pushed the guyn/streams/print_bad_tx branch from 852e9f3 to c08f77b Compare December 10, 2024 09:53
@guy-starkware guy-starkware force-pushed the guyn/streams/hash_map_type branch from 92b40d1 to 389e22b Compare December 10, 2024 10:33
@guy-starkware guy-starkware force-pushed the guyn/streams/print_bad_tx branch from c08f77b to a49ea50 Compare December 10, 2024 10:33
Copy link
Contributor

@matan-starkware matan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @guy-starkware)

Copy link
Contributor Author

guy-starkware commented Dec 10, 2024

Merge activity

@guy-starkware guy-starkware changed the base branch from guyn/streams/hash_map_type to graphite-base/2518 December 10, 2024 14:08
@guy-starkware guy-starkware force-pushed the guyn/streams/print_bad_tx branch from a49ea50 to b720f3f Compare December 10, 2024 16:59
@guy-starkware guy-starkware changed the base branch from graphite-base/2518 to main December 10, 2024 16:59
@guy-starkware guy-starkware force-pushed the guyn/streams/print_bad_tx branch from b720f3f to 61eae2c Compare December 10, 2024 16:59
@guy-starkware guy-starkware force-pushed the guyn/streams/print_bad_tx branch from 61eae2c to 6a806b0 Compare December 11, 2024 16:52
@guy-starkware guy-starkware merged commit 203fb99 into main Dec 11, 2024
14 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants