Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added const-folding *_eq with 0 into *_iz_zero. #6454

Merged
merged 1 commit into from
Oct 6, 2024
Merged

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented Oct 6, 2024

This change is Reviewable

Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 20 files at r1, all commit messages.
Reviewable status: 1 of 20 files reviewed, all discussions resolved

Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 20 files reviewed, 1 unresolved discussion (waiting on @orizi)


crates/cairo-lang-lowering/src/optimizations/const_folding.rs line 734 at r1 (raw file):

}

/// The range of a type for normalizations.

Fix doc

Code quote:

/// The range of a type for normalizations.

Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 1 of 20 files reviewed, 1 unresolved discussion (waiting on @orizi)

@orizi orizi force-pushed the spr/main/a9bfa8e4 branch 2 times, most recently from f21a246 to f3d8bb8 Compare October 6, 2024 12:29
Copy link
Collaborator Author

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 21 files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware)


crates/cairo-lang-lowering/src/optimizations/const_folding.rs line 734 at r1 (raw file):

Previously, gilbens-starkware (Gil Ben-Shachar) wrote…

Fix doc

Done.

Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9 of 20 files at r1, 11 of 11 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @orizi)

@orizi orizi changed the base branch from spr/main/04a3d127 to main October 6, 2024 14:19
@orizi orizi force-pushed the spr/main/a9bfa8e4 branch from f3d8bb8 to 83cbfb1 Compare October 6, 2024 14:19
@orizi orizi enabled auto-merge October 6, 2024 14:20
@orizi orizi added this pull request to the merge queue Oct 6, 2024
Merged via the queue into main with commit 3900e0c Oct 6, 2024
87 checks passed
@orizi orizi deleted the spr/main/a9bfa8e4 branch October 10, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants