-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added const-folding *_eq
with 0 into *_iz_zero
.
#6454
Conversation
55d6230
to
23f29c2
Compare
0052fdd
to
ebbb039
Compare
4f902cb
to
aeaec08
Compare
d9de66b
to
ea61abd
Compare
aeaec08
to
fd40665
Compare
ea61abd
to
733d8c0
Compare
fd40665
to
c998324
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 20 files at r1, all commit messages.
Reviewable status: 1 of 20 files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 20 files reviewed, 1 unresolved discussion (waiting on @orizi)
crates/cairo-lang-lowering/src/optimizations/const_folding.rs
line 734 at r1 (raw file):
} /// The range of a type for normalizations.
Fix doc
Code quote:
/// The range of a type for normalizations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 20 files reviewed, 1 unresolved discussion (waiting on @orizi)
f21a246
to
f3d8bb8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 21 files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware)
crates/cairo-lang-lowering/src/optimizations/const_folding.rs
line 734 at r1 (raw file):
Previously, gilbens-starkware (Gil Ben-Shachar) wrote…
Fix doc
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 9 of 20 files at r1, 11 of 11 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @orizi)
commit-id:a9bfa8e4
f3d8bb8
to
83cbfb1
Compare
This change is