Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added *_eq const folding. #6435

Merged
merged 1 commit into from
Oct 6, 2024
Merged

Added *_eq const folding. #6435

merged 1 commit into from
Oct 6, 2024

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented Sep 30, 2024

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.


This change is Reviewable

Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @orizi)


crates/cairo-lang-lowering/src/optimizations/const_folding.rs line 527 at r2 (raw file):

    /// The set of functions that check if a number is zero.
    nz_fns: OrderedHashSet<ExternFunctionId>,
    /// The set of functions that check if a numbers are equal.

Suggestion:

 /// The set of functions that check if numbers are equal.

@orizi orizi force-pushed the spr/main/34243163 branch from b41927b to ef959b8 Compare October 6, 2024 07:29
@orizi orizi force-pushed the spr/main/5850139f branch from 3b03bed to 7da4fc6 Compare October 6, 2024 07:29
Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 2 files at r1, 1 of 1 files at r3.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @orizi)

Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @orizi)

@orizi orizi force-pushed the spr/main/34243163 branch from ef959b8 to c7426a1 Compare October 6, 2024 07:47
@orizi orizi force-pushed the spr/main/5850139f branch 2 times, most recently from 14765df to 79f69b9 Compare October 6, 2024 09:02
@orizi orizi force-pushed the spr/main/34243163 branch from c7426a1 to 2f15a0b Compare October 6, 2024 09:02
commit-id:5850139f
@orizi orizi changed the base branch from spr/main/34243163 to main October 6, 2024 09:33
@orizi orizi force-pushed the spr/main/5850139f branch from 79f69b9 to 0fa21d5 Compare October 6, 2024 09:33
@orizi orizi enabled auto-merge October 6, 2024 09:36
@orizi orizi added this pull request to the merge queue Oct 6, 2024
Merged via the queue into main with commit 1b6162e Oct 6, 2024
86 of 87 checks passed
@orizi orizi deleted the spr/main/5850139f branch October 10, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants