-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added *_eq
const folding.
#6435
Conversation
608b180
to
e4aa964
Compare
66d5f49
to
be1a334
Compare
e4aa964
to
0c66292
Compare
0c66292
to
b41927b
Compare
be1a334
to
3b03bed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @orizi)
crates/cairo-lang-lowering/src/optimizations/const_folding.rs
line 527 at r2 (raw file):
/// The set of functions that check if a number is zero. nz_fns: OrderedHashSet<ExternFunctionId>, /// The set of functions that check if a numbers are equal.
Suggestion:
/// The set of functions that check if numbers are equal.
b41927b
to
ef959b8
Compare
3b03bed
to
7da4fc6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, 1 of 1 files at r3.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @orizi)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @orizi)
ef959b8
to
c7426a1
Compare
14765df
to
79f69b9
Compare
c7426a1
to
2f15a0b
Compare
commit-id:5850139f
79f69b9
to
0fa21d5
Compare
Stack:
*_eq
with 0 into*_iz_zero
. #6454*_eq
const folding. #6435 ⬅This change is