-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabled const-folding cancelation for e2e tests. #6434
Conversation
608b180
to
e4aa964
Compare
775b76c
to
9bc1305
Compare
e4aa964
to
0c66292
Compare
0c66292
to
b41927b
Compare
9bc1305
to
5325582
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 6 files at r1, all commit messages.
Reviewable status: 2 of 6 files reviewed, 1 unresolved discussion (waiting on @orizi)
tests/e2e_test.rs
line 28 at r1 (raw file):
let mut db = RootDatabase::builder().detect_corelib().build().unwrap(); db.set_optimization_config(Arc::new( OptimizationConfig::default().with_skip_const_folding(true),
Shouldn't it be in addition to with_miniman_moveable_functions
?
Code quote:
OptimizationConfig::default().with_skip_const_folding(true),
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 6 files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware)
tests/e2e_test.rs
line 28 at r1 (raw file):
Previously, gilbens-starkware (Gil Ben-Shachar) wrote…
Shouldn't it be in addition to
with_miniman_moveable_functions
?
no - the only reason that was needed is because of the const folding.
b41927b
to
ef959b8
Compare
5325582
to
aad1e74
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 6 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @orizi)
aad1e74
to
e4398cb
Compare
ef959b8
to
c7426a1
Compare
commit-id:34243163
c7426a1
to
2f15a0b
Compare
Stack:
*_eq
with 0 into*_iz_zero
. #6454*_eq
const folding. #6435This change is