Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled const-folding cancelation for e2e tests. #6434

Merged
merged 1 commit into from
Oct 6, 2024
Merged

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented Sep 30, 2024

Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 6 files at r1, all commit messages.
Reviewable status: 2 of 6 files reviewed, 1 unresolved discussion (waiting on @orizi)


tests/e2e_test.rs line 28 at r1 (raw file):

    let mut db = RootDatabase::builder().detect_corelib().build().unwrap();
    db.set_optimization_config(Arc::new(
        OptimizationConfig::default().with_skip_const_folding(true),

Shouldn't it be in addition to with_miniman_moveable_functions?

Code quote:

OptimizationConfig::default().with_skip_const_folding(true),

Copy link
Collaborator Author

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 6 files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware)


tests/e2e_test.rs line 28 at r1 (raw file):

Previously, gilbens-starkware (Gil Ben-Shachar) wrote…

Shouldn't it be in addition to with_miniman_moveable_functions?

no - the only reason that was needed is because of the const folding.

@orizi orizi force-pushed the spr/main/34243163 branch from b41927b to ef959b8 Compare October 6, 2024 07:29
@orizi orizi force-pushed the spr/main/b582d31f branch from 5325582 to aad1e74 Compare October 6, 2024 07:29
Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 6 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @orizi)

@orizi orizi force-pushed the spr/main/b582d31f branch from aad1e74 to e4398cb Compare October 6, 2024 07:47
@orizi orizi force-pushed the spr/main/34243163 branch from ef959b8 to c7426a1 Compare October 6, 2024 07:47
@orizi orizi changed the base branch from spr/main/b582d31f to main October 6, 2024 09:01
@orizi orizi force-pushed the spr/main/34243163 branch from c7426a1 to 2f15a0b Compare October 6, 2024 09:02
@orizi orizi enabled auto-merge October 6, 2024 09:02
@orizi orizi added this pull request to the merge queue Oct 6, 2024
Merged via the queue into main with commit dbc88ef Oct 6, 2024
86 of 87 checks passed
@orizi orizi deleted the spr/main/34243163 branch October 10, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants