Accept home chain selector id in commit plugin factory #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xnogo
changed the title
makramkd
reviewed
Sep 26, 2024
| @@ -358,6 +358,7 @@ type OCR3Config struct { | |||
| F uint8 `json:"F"` | |||
| OffchainConfigVersion uint64 `json:"offchainConfigVersion"` | |||
| OfframpAddress []byte `json:"offrampAddress"` | |||
| RmnHomeAddress []byte `json:"rmnHomeAddress"` | |||
There was a problem hiding this comment.
This will cause all tests to fail because this is not on-chain yet. I think we should remove this for now and maybe add later when its finally in there?
There was a problem hiding this comment.
Would it be just empty? We are not using it (under the rmn feature flag).
It seems like ccip integ test are passing here: smartcontractkit/chainlink#14500
Test Coverage
|
makramkd
approved these changes
Sep 27, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accept the hom chain selector id in the under the
rmnEnabledflag (otherwise integration test will fail as the RMNHome contract is not ready + RMNHomeAddress is not yet defined in OCR3Config.The Commit factory will instantiate a
RMNHome readerper plugin instance as thermnHomeAddressis part of the OCR3Config, hence not uniquely defined (1 per don id)The build of
chainlinkis failing: here is the PR to mirror the interface changes made in this PR: smartcontractkit/chainlink#14500.