-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RMN home and remote readers #137
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good 🚀, please resolve the minor comments before merging.
And maybe ask another look for sync services.StateMachine
, cause I am not familiar with this library and maybe I didn't spot any issues
} | ||
|
||
// Node mirrors RMNHome.sol's Node struct | ||
type Node struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The structs will be exported in the gethwrappers but we don't have access to gethwrappers here so we have to do this duplication.
} | ||
|
||
// IsNodeObserver checks if a node is an observer for the given source chain | ||
func IsNodeObserver(sourceChain SourceChain, nodeIndex int, totalNodes int) (bool, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method is no doubt useful, but does it make more sense as a method on SourceChain
maybe?
Test Coverage
|
Introduction of an rmn home reader (will be modified with the new RMNHome.sol) and an rmn remote reader.
Also modelled what the data would look like in the offchain code (see types/config.go). This will replace the the /config.go in a later PR.