Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accept home chain selector id in commit plugin factory #140
Accept home chain selector id in commit plugin factory #140
Changes from all commits
9226876
c0f3601
7a51db6
b34bd67
9e2dd6f
bd0196c
a83702e
3a12334
475bde8
f38a867
ae92b12
2bbe887
c484fa8
2bcda39
fb9458a
27eedb7
806e071
2c073c2
42abcf7
aa80e41
f6e5f66
006ff0f
ad31c58
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will cause all tests to fail because this is not on-chain yet. I think we should remove this for now and maybe add later when its finally in there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be just empty? We are not using it (under the rmn feature flag).
It seems like ccip integ test are passing here: smartcontractkit/chainlink#14500