-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update repository permissions and log message when service name is not set #252
Conversation
service.name attribute is not set, your service is unnamed and will be difficult to identify. | ||
set your service name using the OTEL_SERVICE_NAME environment variable. | ||
The service.name resource attribute is not set, your service is unnamed and will be difficult to identify. | ||
Set your service name using the OTEL_SERVICE_NAME or OTEL_RESOURCE_ATTRIBUTES environment variable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can also set the service name via the OTEL_RESOURCE_ATTRIBUTES
setting, I thought the suggested log message should reflect that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had one grammar thing, otherwise fine by me.
Co-authored-by: jason plumb <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only MD lint validation to be fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with this. Lint error has to be fixed.
PS. Next time it would be easier if it would be as two separate PRs 😉 |
Come on, this PR changed 12 LOC in total. |
Several things that I think need to be updated before we can sign off on #248