Update repository permissions and log message when service name is not set #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
commented
Sep 1, 2023
| service.name attribute is not set, your service is unnamed and will be difficult to identify. | ||
| set your service name using the OTEL_SERVICE_NAME environment variable. | ||
| The service.name resource attribute is not set, your service is unnamed and will be difficult to identify. | ||
| Set your service name using the OTEL_SERVICE_NAME or OTEL_RESOURCE_ATTRIBUTES environment variable. |
There was a problem hiding this comment.
You can also set the service name via the OTEL_RESOURCE_ATTRIBUTES setting, I thought the suggested log message should reflect that
mateuszrzeszutek
commented
Sep 1, 2023
breedx-splk
approved these changes
Sep 1, 2023
Co-authored-by: jason plumb <[email protected]>
Kielek
approved these changes
Sep 5, 2023
pellared
approved these changes
Sep 5, 2023
pellared
changed the title
|
PS. Next time it would be easier if it would be as two separate PRs 😉 |
Come on, this PR changed 12 LOC in total. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several things that I think need to be updated before we can sign off on #248