Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix permissions to be applicable for non-instrumentation repositories #256

Merged

Conversation

pellared
Copy link
Contributor

@pellared pellared requested review from a team as code owners September 12, 2023 14:05
@pellared
Copy link
Contributor Author

pellared commented Sep 12, 2023

@mateuszrzeszutek @Kielek PTAL

Related PR #252

@breedx-splk
Copy link
Contributor

Can you elaborate on why you think we need an additional "admin" team? Aren't the maintainers basically admins?

@pellared
Copy link
Contributor Author

pellared commented Sep 12, 2023

Can you elaborate on why you think we need an additional "admin" team? Aren't the maintainers basically admins?

We have gdi-instrumentation-admins team which is added to most (all?) our GDI instrumentation repositories, the other "admin" team is gdi-data-collection-admins.

Copy link
Contributor

@mateuszrzeszutek mateuszrzeszutek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'm fine with that, although I'd prefer the doc to say "at least one of these two teams" explicitly.

@pellared
Copy link
Contributor Author

pellared commented Sep 13, 2023

I think I'm fine with that, although I'd prefer the doc to say "at least one of these two teams" explicitly.

I think we can refine this in a bugfix release. You can also propose a change if you already have an idea how to define it.

Can you elaborate on why you think we need an additional "admin" team? Aren't the maintainers basically admins?

Same as above 😉

@pellared pellared merged commit 9ab69be into signalfx:main Sep 13, 2023
1 check passed
@pellared pellared deleted the gdi-instrumentation-admins-permissions branch September 13, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants