Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update repository permissions and log message when service name is not set #252

Merged
merged 5 commits into from
Sep 6, 2023
Merged

Update repository permissions and log message when service name is not set #252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b413985
Multiple spec updates based on .NET GA review
Sep 1, 2023
97ae5fb
Apply suggestions from code review
Sep 4, 2023
c1edf52
markdownlint
Sep 1, 2023
2b28fd4
remove the gdi-specification-maintainers requirement as well
Sep 5, 2023
318e1db
Merge branch 'main' into spec-updates
pellared Sep 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions specification/configuration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,8 +214,8 @@ are required.
name or link to relevant documentation. E.g.

```txt
service.name attribute is not set, your service is unnamed and will be difficult to identify.
set your service name using the OTEL_SERVICE_NAME environment variable.
The service.name resource attribute is not set. Your service is unnamed and will be difficult to identify.
Set your service name using the OTEL_SERVICE_NAME or OTEL_RESOURCE_ATTRIBUTES environment variable.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also set the service name via the OTEL_RESOURCE_ATTRIBUTES setting, I thought the suggested log message should reflect that

E.g. `OTEL_SERVICE_NAME="<YOUR_SERVICE_NAME_HERE>"`
```

Expand Down
6 changes: 2 additions & 4 deletions specification/repository.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,10 @@ approval is granted, GDI repositories MUST NOT cut a GA release.

- MUST grant `Admin` [permission
level](https://docs.github.com/en/organizations/managing-access-to-your-organizations-repositories/repository-permission-levels-for-an-organization)
to maintainers team
to maintainers team and the `gdi-instrumentation-admins` team
- MUST grant `Write` [permission
level](https://docs.github.com/en/organizations/managing-access-to-your-organizations-repositories/repository-permission-levels-for-an-organization)
to approvers team and the `signalfx/docs`,
`signalfx/gdi-specification-approvers`
`signalfx/gdi-specification-maintainers` teams
to approvers team and the `signalfx/gdi-docs` team
- MUST NOT grant `Write`, `Maintain`, `Admin` [permission
level](https://docs.github.com/en/organizations/managing-access-to-your-organizations-repositories/repository-permission-levels-for-an-organization)
to any other team
Expand Down
2 changes: 1 addition & 1 deletion specification/templates/.github/CODEOWNERS
View file
Open in desktop
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@
*.md @signalfx/gdi-TEAM-maintainers @signalfx/gdi-TEAM-approvers @signalfx/gdi-docs
*.rst @signalfx/gdi-TEAM-maintainers @signalfx/gdi-TEAM-approvers @signalfx/gdi-docs
docs/ @signalfx/gdi-TEAM-maintainers @signalfx/gdi-TEAM-approvers @signalfx/gdi-docs
README* @signalfx/gdi-TEAM-maintainers @signalfx/gdi-TEAM-approvers @signalfx/gdi-docs @signalfx/gdi-specification-approvers @signalfx/gdi-specification-maintainers
README* @signalfx/gdi-TEAM-maintainers @signalfx/gdi-TEAM-approvers @signalfx/gdi-docs