Skip to content

Bump version to 0.20.0 #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Bump version to 0.20.0 #390

wants to merge 2 commits into from

Conversation

wusyong
Copy link
Member

@wusyong wusyong commented Apr 10, 2025

No description provided.

@Legend-Master
Copy link

Just a friendly remainder that this might break things #388 (comment), we probably want or_else instead of or

@wusyong
Copy link
Member Author

wusyong commented Apr 11, 2025

This is minor version bump already. But don't merge it either. I'm trying to test downstream repo like media and servo. I'll open companion PRs to test their CIs too.

@tensor-programming
Copy link
Contributor

tensor-programming commented Apr 11, 2025 •
edited
Loading

Just a friendly remainder that this might break things #388 (comment), we probably want or_else instead of or

I can make a really small pr to change it back if that's what you want; didn't see your comment until just now and I agree.

PR is here: #391

@wusyong wusyong mentioned this pull request Apr 12, 2025
Open
@wusyong
Bump version to 0.20.0
da38829 
Signed-off-by: Wu Yu Wei <[email protected]>
@wusyong wusyong mentioned this pull request Apr 13, 2025
Draft
@wusyong
Revert rand back to 0.8
959e78a 
Signed-off-by: Wu Yu Wei <[email protected]>
@simonwuelker simonwuelker mentioned this pull request May 1, 2025
Merged
jdm
jdm reviewed May 1, 2025
View reviewed changes
src/platform/macos/mod.rs
@@ -267,7 +267,7 @@ impl OsIpcReceiver {
let mut os_result;
let mut name;
loop {
name = format!("{}{}", BOOTSTRAP_PREFIX, rand::rng().random::<i64>());
name = format!("{}{}", BOOTSTRAP_PREFIX, rand::thread_rng().gen::<i64>());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wusyong Can you explain why reverting the change from #387 is needed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot the reason but it's something related to servo's tidy iirc.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably duplicated package version because we have rand 0.8.5 in servo: https://github.com/servo/servo/blob/539ca272843bd0937bc7ed48d6103a6338d2a3c9/Cargo.lock#L5875

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm jdm approved these changes

@sagudev sagudev sagudev left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wusyong @Legend-Master @tensor-programming @jdm @sagudev