Skip to content

Bump version to 0.20.0 #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Bump version to 0.20.0 #390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da38829
Bump version to 0.20.0
wusyong Apr 10, 2025
959e78a
Revert rand back to 0.8
wusyong Apr 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "ipc-channel"
version = "0.19.0"
version = "0.20.0"
description = "A multiprocess drop-in replacement for Rust channels"
authors = ["The Servo Project Developers"]
license = "MIT OR Apache-2.0"
Expand Down Expand Up @@ -45,7 +45,7 @@ mio = { version = "1.0", default-features = false, features = ["os-ext"] }
tempfile = "3.4"

[target.'cfg(target_os = "macos")'.dependencies]
rand = "0.9"
rand = "0.8"

[dev-dependencies]
crossbeam-utils = "0.8"
Expand Down
2 changes: 1 addition & 1 deletion src/platform/macos/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ impl OsIpcReceiver {
let mut os_result;
let mut name;
loop {
name = format!("{}{}", BOOTSTRAP_PREFIX, rand::rng().random::<i64>());
name = format!("{}{}", BOOTSTRAP_PREFIX, rand::thread_rng().gen::<i64>());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wusyong Can you explain why reverting the change from #387 is needed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot the reason but it's something related to servo's tidy iirc.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably duplicated package version because we have rand 0.8.5 in servo: https://github.com/servo/servo/blob/539ca272843bd0937bc7ed48d6103a6338d2a3c9/Cargo.lock#L5875

let c_name = CString::new(name.clone()).unwrap();
os_result = bootstrap_register2(bootstrap_port, c_name.as_ptr(), right, 0);
if os_result == BOOTSTRAP_NAME_IN_USE {
Expand Down