Propagate deserialization errors for IpcSharedMemory #392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Wülker <[email protected]>
simonwuelker
commented
May 1, 2025
Comment on lines
+50
to
+53
| thread::Builder::new() | ||
| .name("router-proxy".to_string()) | ||
| .spawn(move || Router::new(msg_receiver, wakeup_receiver).run()) | ||
| .expect("Failed to spawn router proxy thread"); |
There was a problem hiding this comment.
I gave the router proxy thread a name to make it easier to identify when it panics.
simonwuelker
changed the title
simonwuelker
changed the title
This makes debugging easier when panics occur inside the thread. Signed-off-by: Simon Wülker <[email protected]>
simonwuelker
force-pushed
the
handle-shmem-errors
branch
from
ae47d03 to
7a3fa34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
IpcSharedMemory::deserializereturn an error if the deserialized data references an shared memory region region that does not exist.Part of servo/servo#36792. This doesn't fix the actual issue, but gives users of
ipc-channelthe opportunity to handle the error gracefully. Servo is technically at fault for panicking now, because serialized data being corrupted is not unrealistic.