Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'basic theme' Appearance customization colors #2398

Merged
merged 16 commits into from
Dec 9, 2024
Merged

Conversation

laritakr
Copy link
Collaborator

@laritakr laritakr commented Dec 9, 2024

Fixes color customizations for default views. Additional work is needed for themes.

ref notch8/palni_palci_knapsack#176

A number of class codes changed, between blacklight, bootstrap, and hyrax. This PR adjusts the behavior of the appearance color customizations and/or view partials to restore the color customization behaviors.

Changes proposed in this pull request:

  • fixes "restore all defaults" options
  • fixes some ui errors
  • color customizations now function in the default views (themes still need work)

@samvera/hyku-code-reviewers

LaRita Robinson added 16 commits December 4, 2024 14:42
These were added during knapsacking, but already existed in
another folder.
Carryover from bootstrap update.
Instititional repository layout did not include the class needed
for color customizations.
Also:
Moved into hyku.scss with other Hyku customizations
Removes commented out css
Button 'default' has become secondary.
Some primary buttons have changed to secondary in Hyrax, and changing
others to be consistent on a page.
Unlock Bulkrax to use released gem version released rather than the tag.
@laritakr laritakr added the patch-ver for release notes label Dec 9, 2024
@laritakr laritakr changed the title Fix Appearance customization colors Fix 'basic theme' Appearance customization colors Dec 9, 2024
Copy link

github-actions bot commented Dec 9, 2024

Test Results

    3 files  ±0      3 suites  ±0   18m 4s ⏱️ + 1m 1s
2 055 tests +2  1 999 ✅ +2  56 💤 ±0  0 ❌ ±0 
2 082 runs  +2  2 024 ✅ +2  58 💤 ±0  0 ❌ ±0 

Results for commit dbe7f6b. ± Comparison against base commit a1d7cef.

This pull request removes 42 and adds 44 tests. Note that renamed tests count towards both.
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 126efe65-0bd7-4984-830c-3cf39c2b96ef
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 697fc917-34ec-41f5-b134-f0d3d409dfff
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 6cb1fc1b-d6ca-43fe-a811-0d192063c737
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 38acbc82-7f50-47c6-b64c-2050c78ade76
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 27bd1ef0-325b-4bc9-afd8-ca5a4792c035
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit f2ffc875-1206-4698-90a2-3f38bf3ea4c9
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read fc6be345-82eb-4d94-8184-63ef5261014d
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update b16acc7a-e800-4090-8279-c841a07d553b
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy ebcdc569-6842-42a3-ac75-633c007f8c29
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 963b004b-e5e9-4a31-b493-4f49fda54f2e
…
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 925da701-22f0-496b-a875-cdc6003c5b8f
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit aa89fa2f-fbfe-477f-a6e5-e69814e683b4
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read a65691b7-350a-4a74-8bd7-1a99c716a67e
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 27802b2c-fed1-43a3-a797-99480ce803f3
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy f746e426-2c78-41df-a846-fdfe37400eb7
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit b6380129-32a5-4c60-b743-073d445326da
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 4523a289-ef90-4463-8712-bfedde44b0d8
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 9fe9421b-5ad1-40d4-bfe9-d032b83db1b7
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 90af8f0d-47af-476b-a895-b8aacdb12941
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 13ee292b-7da5-40ac-9a7e-5f61f88dbc60
…

Copy link
Collaborator

@kirkkwang kirkkwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good!

@laritakr laritakr merged commit b247dd6 into main Dec 9, 2024
8 of 9 checks passed
@laritakr laritakr deleted the appearance-colors branch December 9, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants