-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 'basic theme' Appearance customization colors #2398
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were added during knapsacking, but already existed in another folder.
Carryover from bootstrap update.
Instititional repository layout did not include the class needed for color customizations.
Also: Moved into hyku.scss with other Hyku customizations Removes commented out css
Button 'default' has become secondary. Some primary buttons have changed to secondary in Hyrax, and changing others to be consistent on a page.
Unlock Bulkrax to use released gem version released rather than the tag.
laritakr
changed the title
Fix Appearance customization colors
Fix 'basic theme' Appearance customization colors
Dec 9, 2024
Test Results 3 files ±0 3 suites ±0 18m 4s ⏱️ + 1m 1s Results for commit dbe7f6b. ± Comparison against base commit a1d7cef. This pull request removes 42 and adds 44 tests. Note that renamed tests count towards both.
|
kirkkwang
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks good!
This was referenced Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes color customizations for default views. Additional work is needed for themes.
ref notch8/palni_palci_knapsack#176
A number of class codes changed, between blacklight, bootstrap, and hyrax. This PR adjusts the behavior of the appearance color customizations and/or view partials to restore the color customization behaviors.
Changes proposed in this pull request:
@samvera/hyku-code-reviewers