Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap 4 uses card instead of panel #2399

Merged
merged 1 commit into from
Dec 20, 2024
Merged

bootstrap 4 uses card instead of panel #2399

merged 1 commit into from
Dec 20, 2024

Conversation

orangewolf
Copy link
Member

No description provided.

@laritakr
Copy link
Collaborator

I fixed a lot of the color issues in this PR: #2398

I'm surprised you found this many more problems, though I didn't go through the theme files yet.

@orangewolf orangewolf added the patch-ver for release notes label Dec 12, 2024
@orangewolf
Copy link
Member Author

@laritakr I was trying to fix the bulkrax theming and noticed it was an across the board problem with panel / panel-body.

@laritakr
Copy link
Collaborator

@laritakr I was trying to fix the bulkrax theming and noticed it was an across the board problem with panel / panel-body.

Yes I found quite a few of them when I was working on the colors, but I guess I didn't do an across the board search since I ran out of time to work on pals issues.

Copy link

github-actions bot commented Dec 12, 2024

Test Results

    3 files  ±0      3 suites  ±0   17m 54s ⏱️ -2s
2 055 tests ±0  1 998 ✅ ±0  56 💤 ±0  1 ❌ ±0 
2 082 runs  ±0  2 023 ✅ ±0  58 💤 ±0  1 ❌ ±0 

For more details on these failures, see this check.

Results for commit cac96ff. ± Comparison against base commit b247dd6.

This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both.
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 03ef3316-6a60-4cea-b31d-c8b3db9b4148
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit e43698b6-f941-4a4b-b31f-c019abbc5886
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read f20cff5c-7e89-4651-bb52-b3bfe603edce
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 8e1b284c-5a07-46b3-83a4-96596a53d3d5
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy c2bc869f-3186-4c92-ad06-08602d31fd06
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit bfb6ad93-9b7d-4895-886f-cd353243fc2c
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 53def0ed-6ac2-4f99-ad38-a85051967f62
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update f8e7cb4c-348a-42b0-988b-087ed33305fc
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 5abac8aa-2fb0-4b30-af71-92edea9bf114
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 6012f540-392d-4fbd-9eb4-e9eda802f853
…
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 1b63fd25-fea7-4fa4-a11f-f52a65d72683
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 4342a160-75c0-40a6-8207-60913cd87975
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read ac5b83ab-5a86-4798-a14e-4dde64298905
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 7a772fe4-322c-4901-b0a0-7fb1b7cd7458
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 940a23a0-8d1d-4555-afb6-2ce51b9c57d1
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 608a0f8b-1028-4c63-988f-c8d59e5cb878
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 8c4daeb4-50d6-471f-957f-773838052d20
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update aa2595f3-8b18-43bc-a009-2f1c0778bc79
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy f9514f0d-ee72-49a4-8cf7-181e2bbaa062
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit d6626f26-20a1-4a22-99c1-5b60b262e8ba
…

♻️ This comment has been updated with latest results.

@orangewolf orangewolf merged commit 84b083e into main Dec 20, 2024
6 of 9 checks passed
@orangewolf orangewolf deleted the panel-to-card branch December 20, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants