Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final appearance color fixes #2406

Merged
merged 3 commits into from
Jan 10, 2025
Merged

Final appearance color fixes #2406

merged 3 commits into from
Jan 10, 2025

Conversation

laritakr
Copy link
Collaborator

Builds on and completes prior appearance color fixes:

Prior work had not verified that colors applied appropriately to themes.
All themes and colors were tested and only a few minor revisions were needed.

LaRita Robinson added 2 commits January 10, 2025 16:49
Use of this color is not obvious, and applies only to default theme.
@laritakr laritakr added the patch-ver for release notes label Jan 10, 2025
Copy link

github-actions bot commented Jan 10, 2025

Test Results

    3 files  +  1      3 suites  +1   18m 36s ⏱️ + 5m 2s
2 055 tests +690  1 999 ✅ +674  56 💤 +16  0 ❌ ±0 
2 082 runs  +698  2 024 ✅ +682  58 💤 +16  0 ❌ ±0 

Results for commit 09a6ced. ± Comparison against base commit 45ea8dc.

This pull request removes 40 and adds 730 tests. Note that renamed tests count towards both.
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 6dae1e54-91d7-4f50-a060-41b3912658e5
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit f227f97b-2ff0-448f-b1fb-09222d446b2c
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read d3a7e358-8f3e-4c84-b559-75f40bd79488
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 92fab664-f76e-473b-835d-e68efc87b6b2
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 36a7f77c-1ce8-44e0-9d65-cb3c416fcdcb
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit a81d3037-6cb4-40b0-8ac8-feb9af4a26c9
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 06bfaeee-1bb0-417f-9978-dfda1080baa9
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 42360754-fbfa-4dce-9ca2-b40efdcfa4fd
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 44f79885-1e85-47d3-b112-05c67f8a90cb
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 10c0ef8e-cd1c-4624-829d-d3c884430e1d
…
spec.abilities.collection_ability_spec ‑ Hyrax::Ability::CollectionAbility create_any when there are collection types that have create access allows create_any
spec.abilities.collection_ability_spec ‑ Hyrax::Ability::CollectionAbility create_any when there are no collection types that have create access denies create_any
spec.abilities.collection_ability_spec ‑ Hyrax::Ability::CollectionAbility when a user has a Collection Editor role through its User roles allows most abilities but denies ability to destroy and manage discovery
spec.abilities.collection_ability_spec ‑ Hyrax::Ability::CollectionAbility when a user has a Collection Editor role through its group memberships allows most abilities but not destroy nor manage_discovery
spec.abilities.collection_ability_spec ‑ Hyrax::Ability::CollectionAbility when a user has a Collection Reader role through its User roles allows read abilities but denies others
spec.abilities.collection_ability_spec ‑ Hyrax::Ability::CollectionAbility when a user has a Collection Reader role through its group memberships allows read abilities but denies others
spec.abilities.collection_ability_spec ‑ Hyrax::Ability::CollectionAbility when a user is a Collection Manager through its User roles allows all abilities
spec.abilities.collection_ability_spec ‑ Hyrax::Ability::CollectionAbility when a user is a Collection Manager through its group memberships allows all abilities
spec.abilities.collection_ability_spec ‑ Hyrax::Ability::CollectionAbility when admin user allows all abilities
spec.abilities.collection_ability_spec ‑ Hyrax::Ability::CollectionAbility when collection depositor allows deposit related abilities and denies non-deposit related abilities
…

♻️ This comment has been updated with latest results.

@ShanaLMoore ShanaLMoore merged commit 78d79ae into main Jan 10, 2025
8 checks passed
@ShanaLMoore ShanaLMoore deleted the appearance-colors-for-themes branch January 10, 2025 23:36
ShanaLMoore added a commit to notch8/palni_palci_knapsack that referenced this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants