-
-
Notifications
You must be signed in to change notification settings - Fork 882
web/audio: Dynamic buffer size #9671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
web/audio: Dynamic buffer size #9671
Conversation
I wonder whether the SWF mentioned in #7532 (https://www.free-culture.tk/lfc-presentation.swf) could be a good test case. That issue describes that playing the animation at full screen (it is actually a presentation) without hardware acceleration causes suboptimal audio playing (display is a 27″-screen). What I also accidentally discovered some days ago is that Ruffle has problems playing sound from https://www.free-culture.tk/lfc-presentation.swf, but not from https://www.free-culture.tk/free_culture.swf. The second link in last paragraph points to the original presentation (made with Macromedia Flash 8 [to the best of my knowledge]) and the first link points to a version made with SWFTools from the same sources. I’m going to investigate the issue further. Many thanks for your help. |
Thank you for the suggestions @ousia! Once I get something that actually works, I might test those too! |
Many thanks for your work on this PR, @torokati44. BTW, if you feel in the mood, it would be great to have |
5884e55
to
9f8e8ae
Compare
At least in my limited testing, this now appears to do what it's supposed to:
More investigation is needed though, to make sure. |
726abdd
to
634008f
Compare
634008f
to
ec3e18f
Compare
I would be more than happy to help, but I don‘t know how to get selfhosted build. Many thanks for your excellent work. |
6cf2561
to
6496cce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me but I'm definitely not an expert in this area :D
Thanks for checking it out! And, well, neither am I! 😅 |
6496cce
to
f4197ed
Compare
f4197ed
to
257711a
Compare
That's great to hear, thank you! |
I just did a few quick tests and this seems to be working exactly as intended! In Bloons 2, which previously had very choppy audio, now the audio is delayed but mostly smooth, except in the very most demanding sections. And games that ran smoothly seem unchanged, with no additional audio delay introduced. Nicely done! 😃 |
Thanks to you too, and also good to hear! ^^ |
d809aee
to
e682898
Compare
e682898
to
ae7a9f3
Compare
@torokati44, sorry but I’m afraid that right now I don’t have access to the device that caused #7532. I hope to have it in a not so distant future and be able to close that issue. Many thanks for your help and your code. |
This is not done yet, just pushing for visibility.The goal is to: