-
-
Notifications
You must be signed in to change notification settings - Fork 882
web: Fixed missing log messages when in futures, or using log
crate
#9824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Do you think this is also why I wasn't seeing |
It makes sense! There might be other areas we're entering into Ruffle which isn't wrapped, but I think this was it from what I saw |
Not specifically related to this PR, but I would like to mention that since #9026 it is possible to experience serious slowdowns in Firefox when a file logs a lot of messages into the browser's console - even if the user never opens the console (which is the difference with the previous behavior). The issue is particularly noticeable in Critical Zone:
So I was wondering if there is anything we can do on our end to prevent that or if this is just an issue related to Firefox (as Chrome doesn't seem affected). |
Can you try the latest commit and see if it helps for you? It seems to for me but I don't want to rule out it being a fluke of me testing |
Yes, I confirm there's no more slowdown on my end as well. Thank you for the fix. 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see nothing obviously wrong with the code (not that I'm an expert in this area... 😉), and I can confirm it fixes at least one annoying issue (that of missing log messages from the audio callback), so LGTM I guess!
No description provided.