Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: json marshal l errors when parsing poll response from klaviyo #5316

Merged
merged 11 commits into from
Dec 9, 2024
Merged
21 changes: 21 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,26 @@
# Changelog

## [1.38.3](https://github.com/rudderlabs/rudder-server/compare/v1.38.2...v1.38.3) (2024-11-20)


### Bug Fixes

* allow only enabled dest in backendSubscriber, fix klaviyo bulk ([#5309](https://github.com/rudderlabs/rudder-server/issues/5309)) ([8808245](https://github.com/rudderlabs/rudder-server/commit/8808245065fb1fcb41d9b1e845b2a69b6847e073))

## [1.38.2](https://github.com/rudderlabs/rudder-server/compare/v1.38.1...v1.38.2) (2024-11-19)


### Bug Fixes

* klaviyo bulk upload and BingAds OC ([#5305](https://github.com/rudderlabs/rudder-server/issues/5305)) ([9c9ef73](https://github.com/rudderlabs/rudder-server/commit/9c9ef73d16326e4a12a69cebe0f71656b4928d42))

## [1.38.1](https://github.com/rudderlabs/rudder-server/compare/v1.38.0...v1.38.1) (2024-11-14)


### Bug Fixes

* bq partitioning for additional columns ([#5293](https://github.com/rudderlabs/rudder-server/issues/5293)) ([4da3bf1](https://github.com/rudderlabs/rudder-server/commit/4da3bf17e790cbc1876714c401b0895b2e9f8521))

## [1.38.0](https://github.com/rudderlabs/rudder-server/compare/v1.37.0...v1.38.0) (2024-11-11)


Expand Down
196 changes: 38 additions & 158 deletions mocks/router/klaviyobulkupload/klaviyobulkupload_mock.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -539,14 +539,14 @@ var _ = Describe("Bing ads Offline Conversions", func() {
Expect(err).To(BeNil())
})

It("Transform() Test -> conversionAdjustedTime not available", func() {
It("Transform() Test -> adjustedConversionTime not available", func() {
job := &jobsdb.JobT{
EventPayload: []byte("{\"type\": \"record\", \"action\": \"update\", \"fields\": {\"conversionName\": \"Test-Integration\", \"conversionTime\": \"5/22/2023 6:27:54 AM\", \"conversionValue\": \"100\", \"microsoftClickId\": \"click_id\", \"conversionCurrencyCode\": \"USD\"}}"),
}
uploader := &BingAdsBulkUploader{}
// Execute
_, err := uploader.Transform(job)
expectedResult := fmt.Errorf(" conversionAdjustedTime field not defined")
expectedResult := fmt.Errorf(" adjustedConversionTime field not defined")
Expect(err.Error()).To(Equal(expectedResult.Error()))
})
})
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ func (b *BingAdsBulkUploader) Transform(job *jobsdb.JobT) (string, error) {
}
if event.Action != "insert" {
// validate for adjusted time
err := validateField(fields, "conversionAdjustedTime")
err := validateField(fields, "adjustedConversionTime")
if err != nil {
return payload, err
}
Expand Down
Loading
Loading