Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: json marshal l errors when parsing poll response from klaviyo #5316

Merged
merged 11 commits into from
Dec 9, 2024

Merge branch 'master' into fix.klaviyo-poll-json-marshall-issues

002defa
Select commit
Loading
Failed to load commit list.
Merged

fix: json marshal l errors when parsing poll response from klaviyo #5316

Merge branch 'master' into fix.klaviyo-poll-json-marshall-issues
002defa
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 9, 2024 in 0s

74.71% (-0.10%) compared to dc446ee

View this Pull Request on Codecov

74.71% (-0.10%) compared to dc446ee

Details

Codecov Report

Attention: Patch coverage is 51.85185% with 13 lines in your changes missing coverage. Please review.

Project coverage is 74.71%. Comparing base (dc446ee) to head (002defa).

Files with missing lines Patch % Lines
...destinationmanager/klaviyobulkupload/apiService.go 42.85% 12 Missing ⚠️
...tionmanager/klaviyobulkupload/klaviyobulkupload.go 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5316      +/-   ##
==========================================
- Coverage   74.80%   74.71%   -0.10%     
==========================================
  Files         437      437              
  Lines       61211    61230      +19     
==========================================
- Hits        45788    45747      -41     
- Misses      12900    12947      +47     
- Partials     2523     2536      +13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov