-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: json marshal l errors when parsing poll response from klaviyo #5316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: bing ads audience (#5299) * chore: handle 500kb limit, refactor to service impl (#5302) * chore: handle 500kb limit, refactor to service impl * chore: fix mock * chore: fix mock newline * chore: fix apiservice newline * chore: move error --------- Co-authored-by: Sudip Paul <[email protected]>
yashasvibajpai
approved these changes
Nov 21, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5316 +/- ##
==========================================
- Coverage 74.80% 74.71% -0.10%
==========================================
Files 437 437
Lines 61211 61230 +19
==========================================
- Hits 45788 45747 -41
- Misses 12900 12947 +47
- Partials 2523 2536 +13 ☔ View full report in Codecov by Sentry. |
krishna2020
reviewed
Nov 22, 2024
router/batchrouter/asyncdestinationmanager/klaviyobulkupload/klaviyobulkupload.go
Show resolved
Hide resolved
krishna2020
approved these changes
Dec 9, 2024
…destination (#5353) * fix: allow only enabled dest in backendSubscriber, fix klaviyo bulk * chore: add rate limited http client for klaviyo bulk * refactor: add rate limiter klaviyo bulk upload --------- Co-authored-by: Dilip Kola <[email protected]>
This was referenced Dec 9, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is a bug in the Klaviyo implementation where, at times, we receive an empty import ID from the upload. However, when we poll with an empty import ID, we encounter parsing errors because Klaviyo returns a list response when the import ID is empty.
Linear Ticket
https://linear.app/rudderstack/issue/INT-2820/klaviyo-bulk-upload-at-times-they-are-running-into-errors
Resolves INT-2820
Security