157 update board interface #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the aircraft actually loads all parameters in sim, but it won't arm. I have not tested if all RC inputs fail, though it is likely.
The firmware appears to be functional.
The sim works for waypoint missions.
|
I am curious as to your thoughts with the having the SENSOR_has_new_data() methods always returning true. |
|
There was a bug with the return true, so I adjusted it to match the imu_new_data which uses gazebo time. This can be easily switched to generic sim time when we finally disconnect gazebo. |
bsutherland333
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The interface changes have been made. They assume that the sensors always have new data when queried. This hasn't caused strange behavior, and I believe that is how it was done before changing the interface. Just something that seems odd.