Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Continue development and upstream #94

Conversation

hoffmann-stefan
Copy link
Member

@hoffmann-stefan hoffmann-stefan commented Jun 15, 2022

from #49 (comment):

Though I have to be honest, depending on when this will be finished (or at least
in a somewhat usable state compatible to the other APIs in #90) we can use this.
On the other hand if this isn't ready when we need the features in our internal
code I may not have a choice but implement this myself in order to avoid
delaying the development of our internal stuff/products.

[...]

In the case that I implement this for our internal products I would continue
sharing the code in the open and finding a way to contribute this back or
helping integrating your/other implementations into the main branch, including
updating our internal code afterwards to be on the main branch of this project
once actions are merged (with all the qualities described in my first post in
this issue).

Now we are at the state where we need action support next.
As described above we would like to contribute to the open and avoid doing a hard fork.
This PR is a grab bag of what is comming next on our development roadmap for this library.
I avoid to do multiple PRs that depend on each other for now, those will be done one the main branch moves forward. I will be using prefixes in the commit messages how those would be grouped to seperate PRs so this should be easyer later on.

Current roadmap:

  • Fix some warnings (so other warnings don't get lost while developing).
  • Use dotnet code style (so I don't constantly fight my habbits and editor configuration).
  • Add support for GuardConditions.
  • Add support for SynchronizationContext to make async code easier. -> Add support for SynchronizationContext #112
  • Add support for action service and client. Support for Actions #49
    • IDL message generation.
    • Add basic action client
    • Add basic action service
    • Testing.

cc @esteve @ooeygui @shschaefer

@pabloinigoblasco
Copy link

Hello. What is the state of this development now?
Is it something we could try?

@hoffmann-stefan
Copy link
Member Author

@pabloinigoblasco

This is work in progress, though we use this internally for our products as we need the features right now.
Should be fine to checkout and test and give feedback.
Though I may do some force-pushes here as I develop this further, and there might be breaking changes as well. But better then nothing if you need the features. Maybe use a copy of this branch that you can update independently of me pushing things here.

@esteve stated some days ago that he wants to look at my other PRs (that this is based on) and likely merge them to main: #90 (comment)

@hoffmann-stefan
Copy link
Member Author

Closing this PR as all parts where now extracted into seperate PRs and only one PR is missing to be merged. So this PR dosn't provide any more use (for now it was the PR with all not merged changes integrated), but as only one is left to merge #108 can be used instead.

This is the list of all PRs that came out of this:

@hoffmann-stefan hoffmann-stefan deleted the continue-develop-and-upstream branch May 29, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants