Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Continue development and upstream #94

Closed
wants to merge 24 commits into from
Closed

[WIP] Continue development and upstream #94

wants to merge 24 commits into from

Commits on May 19, 2023

  1. actions: initial action idl generation

    @hoffmann-stefan
    hoffmann-stefan committed May 19, 2023
    Configuration menu
    Copy the full SHA
    5512e7e View commit details
    Browse the repository at this point in the history

  2. actions: extend idl generation to include interfaces for "action wrap… 

    …per types"

With "action wrapper types" this means the ROS messages and services that add the `GoalId`, `TimeStamp` or other fields on top of the user defined types for the action.
The introduced methods in `IRosActionDefinition` are needed to work around the missing existential type support in C# (dotnet/csharplang#5556).
    @hoffmann-stefan
    hoffmann-stefan committed May 19, 2023
    Configuration menu
    Copy the full SHA
    e146a1f View commit details
    Browse the repository at this point in the history

  3. actions: add accessors to UUID and Time properties for "action wr… 

    …apper types"

This uses the base type `IMessage` to get around the cyclic references.
    @hoffmann-stefan
    hoffmann-stefan committed May 19, 2023
    Configuration menu
    Copy the full SHA
    811170e View commit details
    Browse the repository at this point in the history

  4. actions: add ActionDefinitionStaticMemberCache

    @hoffmann-stefan
    hoffmann-stefan committed May 19, 2023
    Configuration menu
    Copy the full SHA
    78b39d1 View commit details
    Browse the repository at this point in the history

  5. actions: add public action client API without implementation

    @hoffmann-stefan
    hoffmann-stefan committed May 19, 2023
    Configuration menu
    Copy the full SHA
    fcc3cb1 View commit details
    Browse the repository at this point in the history

  6. actions: rename ServiceIsReady() to ServerIsReady() and move to b… 

    …ase class
    @hoffmann-stefan
    hoffmann-stefan committed May 19, 2023
    Configuration menu
    Copy the full SHA
    db7f9a0 View commit details
    Browse the repository at this point in the history

  7. actions: add helper for converting guid <-> uuid

    @hoffmann-stefan
    hoffmann-stefan committed May 19, 2023
    Configuration menu
    Copy the full SHA
    e672ca1 View commit details
    Browse the repository at this point in the history

  8. actions: implement basic action client

    @hoffmann-stefan
    hoffmann-stefan committed May 19, 2023
    Configuration menu
    Copy the full SHA
    d7bd8b6 View commit details
    Browse the repository at this point in the history

  9. actions: add public action server API without implementation

    @hoffmann-stefan
    hoffmann-stefan committed May 19, 2023
    Configuration menu
    Copy the full SHA
    526deb3 View commit details
    Browse the repository at this point in the history

  10. actions: add missing license header

    @hoffmann-stefan
    hoffmann-stefan committed May 19, 2023
    Configuration menu
    Copy the full SHA
    b3f0fda View commit details
    Browse the repository at this point in the history

  11. actions: Change IsCancelRequested to IsCanceling, add IsExecuting

    @hoffmann-stefan
    hoffmann-stefan committed May 19, 2023
    Configuration menu
    Copy the full SHA
    98faadd View commit details
    Browse the repository at this point in the history

  12. actions: Add ReadFromMessageHandle/WriteToMessageHandle helper mehtods

    @hoffmann-stefan
    hoffmann-stefan committed May 19, 2023
    Configuration menu
    Copy the full SHA
    705e8bb View commit details
    Browse the repository at this point in the history

  13. actions: implement basic action server

    @hoffmann-stefan
    hoffmann-stefan committed May 19, 2023
    Configuration menu
    Copy the full SHA
    8f5ce01 View commit details
    Browse the repository at this point in the history

  14. actions: add example action client and server

    @hoffmann-stefan
    hoffmann-stefan committed May 19, 2023
    Configuration menu
    Copy the full SHA
    7ee301e View commit details
    Browse the repository at this point in the history

  15. actions: make local variable name more obvious

    @hoffmann-stefan
    hoffmann-stefan committed May 19, 2023
    Configuration menu
    Copy the full SHA
    25e04a8 View commit details
    Browse the repository at this point in the history

  16. actions: use return value from Interlocked.CompareExchange 

    The field access after Interlocked.CompareExchange might not reflect the updated value.
Or does it? Anyways this makes it more clear.
    @hoffmann-stefan
    hoffmann-stefan committed May 19, 2023
    Configuration menu
    Copy the full SHA
    1098b88 View commit details
    Browse the repository at this point in the history

  17. actions: reorder HandleGoalResponse, HandleStatusMessage and HandleFe… 

    …edbackMessage
    @hoffmann-stefan
    hoffmann-stefan committed May 19, 2023
    Configuration menu
    Copy the full SHA
    3552b8f View commit details
    Browse the repository at this point in the history

  18. actions: handle action specific take failed error codes

    @hoffmann-stefan
    hoffmann-stefan committed May 19, 2023
    Configuration menu
    Copy the full SHA
    e18b37a View commit details
    Browse the repository at this point in the history

  19. actions: publish status before sending the result response

    @hoffmann-stefan
    hoffmann-stefan committed May 19, 2023
    Configuration menu
    Copy the full SHA
    5bada3b View commit details
    Browse the repository at this point in the history

  20. actions: fix typo in dependency

    @hoffmann-stefan
    hoffmann-stefan committed May 19, 2023
    Configuration menu
    Copy the full SHA
    23b1455 View commit details
    Browse the repository at this point in the history

  21. bool pInvoke: Fix bool pInvokes in rcldotnet

    @hoffmann-stefan
    hoffmann-stefan committed May 19, 2023
    Configuration menu
    Copy the full SHA
    419e0df View commit details
    Browse the repository at this point in the history

  22. bool pInvoke: Fix bool pInvokes in generated messages 

    This does not change the C# side of the generated messages to avoid even more complexity in the templates.
As bools in C# pInvokes get marshalled as 32 bit integer by default there is no strictly need to change the code for bool fields.
    @hoffmann-stefan
    hoffmann-stefan committed May 19, 2023
    Configuration menu
    Copy the full SHA
    7c04354 View commit details
    Browse the repository at this point in the history

  23. qos: add quality of service for publishers and subscribers. 

    Most of the documentation was taken from ros2_rust. https://github.com/ros2-rust/ros2_rust/blob/main/rclrs/src/qos.rs
    @hoffmann-stefan
    hoffmann-stefan committed May 19, 2023
    Configuration menu
    Copy the full SHA
    dfda4e0 View commit details
    Browse the repository at this point in the history

  24. qos: fix enum casts for humble (and maybe galactic)

    @hoffmann-stefan
    hoffmann-stefan committed May 19, 2023
    Configuration menu
    Copy the full SHA
    677aa1a View commit details
    Browse the repository at this point in the history