Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use consistent dotnet/C# code-style #100

Merged

Conversation

hoffmann-stefan
Copy link
Member

@hoffmann-stefan hoffmann-stefan commented Apr 22, 2023

extracted from #94

This PR is only about the C# code-style, this doesn't touch the other file-types.

The Coding Style Conventions from the book "Framework Design Guidelines" are the starting point.
They are derived from this file, which is the coding style for the .NET runtime.

@hoffmann-stefan hoffmann-stefan marked this pull request as ready for review April 23, 2023 08:06
@esteve esteve deleted the branch ros2-dotnet:main May 2, 2023 13:25
@esteve esteve closed this May 2, 2023
@hoffmann-stefan hoffmann-stefan changed the base branch from master to main May 2, 2023 17:11
This was done with an temporary *.csproj file in the root of the repository:

```xml
<Project Sdk="Microsoft.NET.Sdk">
  <PropertyGroup>
    <TargetFramework>netstandard2.0</TargetFramework>
  </PropertyGroup>
</Project>
```

Then run command `dotnet format` (from .NET6) in the root of the repository.

Did some manual whitespace changes as well, mainly indented wrapped parameters.
@hoffmann-stefan hoffmann-stefan merged commit 661105f into ros2-dotnet:main May 15, 2023
@hoffmann-stefan hoffmann-stefan deleted the feature/dotnet-codestyle branch May 15, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants