Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove roslib.load_manifest #201

Merged
merged 1 commit into from
Mar 3, 2025
Merged

Conversation

furushchev
Copy link
Contributor

Loading this module is slow, especially on a slow disk I/O machine.
After profiling, I found the roslib.load_manifest crawls the workspace which slows down the importing.
In this PR, the function calls are removed, as the function is not required nowadays on the latest ROS distribution.

@furushchev
Copy link
Contributor Author

@gbiggs Kindly ping to the maintainer

@furushchev
Copy link
Contributor Author

@gbiggs Is this repository inactive? How can I proceed with the review process?

@furushchev
Copy link
Contributor Author

@mjcarroll @gbiggs What is the maintenance status of this package?

@furushchev
Copy link
Contributor Author

@mjcarroll @gbiggs It has been two weeks. Is there any progress?

Copy link
Member

@130s 130s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a maintainer though.

Such an old tradition I forgot what it was, looks like from pre-Catkin era (robotics.stackexchange.com#56413) so should not harm these days.

UPDATE Almost identical to #165

@mjcarroll
Copy link
Member

@furushchev apologies for the delay. As noetic is reaching end-of-life in ~3 months, the ROS 1 repositories are much lower priority for maintenance.

@mjcarroll mjcarroll closed this Feb 16, 2025
@mjcarroll mjcarroll reopened this Feb 16, 2025
@furushchev
Copy link
Contributor Author

Thank you for your review!

As noetic is reaching end-of-life in ~3 months, the ROS 1 repositories are much lower priority for maintenance.

That makes sense. However, from 2023/9/25, when this PR was opened, the EOL was approximately 2 years away...
In any case, if there are no problems, please merge and release it

@mjcarroll mjcarroll merged commit 323d2cd into ros:noetic-devel Mar 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants