Fix typo in README.md and fix CI from forks #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This one is actually from my fork...
|
Ok @ct2034 , the lint action actually did not run from forks but I just changed it so it does. |
|
Ah, we need to only push to GHCR if not on a fork, will do that next. |
No I think that should be good. It will be tagged based on the branch and only main pushes as latest. That’s how I set it up anyway |
|
Ah yes. You are right. Sorry |
ct2034
reviewed
Oct 18, 2024
|
Can you also add the condition to the release step? Sorry I am on my phone in the keynote of Magnus egerstedt ;) |
sea-bass
changed the title
facontidavide
approved these changes
Oct 18, 2024
ct2034
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one is actually from my fork...