Skip to content

Commit

Permalink
Fix typo in README.md and fix CI from forks (#76)
Browse files Browse the repository at this point in the history
* Fix typo and add URL to README.md

This one is actually from my fork...

* Update lint.yml

* Do not push to ghcr from forks

* Gate release step as well
  • Loading branch information
sea-bass authored Oct 18, 2024
1 parent 9fb0365 commit adaa0ff
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
6 changes: 5 additions & 1 deletion .github/workflows/docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,9 @@ jobs:
src/technologies/convince/task_2_solution/
docker compose run test bash -c "source /delib_ws/install/setup.bash && pytest /delib_ws/src/dependencies/convince/AS2FM/test"
docker compose down --remove-orphans
- name: Push to gh registry with sha and branch name
- name: Push to gh registry with sha and branch
# Do not push on PRs from forks.
if: ${{ !github.event.pull_request.head.repo.fork }}
run: |
echo ${{ secrets.GITHUB_TOKEN }} | docker login ghcr.io -u ${{ github.repository_owner }} --password-stdin
# tag with sha and push
Expand All @@ -72,6 +74,8 @@ jobs:
run: |
docker save ${{ env.REGISTRY_IMAGE }}:${{ env.TAG_NAME }} | gzip > ./roscon_delib_ws_2024.tar.gz
- name: Release
# Do not release on PRs from forks.
if: ${{ !github.event.pull_request.head.repo.fork }}
uses: ncipollo/release-action@v1
with:
artifacts: './roscon_delib_ws_2024.tar.gz'
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ on:
push:
branches: [main]
pull_request:
branches: [main]

jobs:
pre-commit:
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ It will ask you for your `sudo` password.
### Develop inside the container using VSCode

If you want to develop inside the container using VSCode, you need to have the [Docker extension](https://marketplace.visualstudio.com/items?itemName=ms-azuretools.vscode-docker) installed.
To see option "Attach Visual Studio Code" you also need to download VS Code extenstion Dev Containers.
To see the option "Attach Visual Studio Code", you also need to download the [Dev Containers extension](https://marketplace.visualstudio.com/items?itemName=ms-vscode-remote.remote-containers).

Attach to the container as shown in the image below:

Expand Down

0 comments on commit adaa0ff

Please sign in to comment.