Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in README.md and fix CI from forks #76

Merged
merged 4 commits into from
Oct 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/docker.yml
ct2034 marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,9 @@ jobs:
src/technologies/convince/task_2_solution/
docker compose run test bash -c "source /delib_ws/install/setup.bash && pytest /delib_ws/src/dependencies/convince/AS2FM/test"
docker compose down --remove-orphans
- name: Push to gh registry with sha and branch name
- name: Push to gh registry with sha and branch
# Do not push on PRs from forks.
if: ${{ !github.event.pull_request.head.repo.fork }}
run: |
echo ${{ secrets.GITHUB_TOKEN }} | docker login ghcr.io -u ${{ github.repository_owner }} --password-stdin
# tag with sha and push
Expand All @@ -72,6 +74,8 @@ jobs:
run: |
docker save ${{ env.REGISTRY_IMAGE }}:${{ env.TAG_NAME }} | gzip > ./roscon_delib_ws_2024.tar.gz
- name: Release
# Do not release on PRs from forks.
if: ${{ !github.event.pull_request.head.repo.fork }}
uses: ncipollo/release-action@v1
with:
artifacts: './roscon_delib_ws_2024.tar.gz'
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ on:
push:
branches: [main]
pull_request:
branches: [main]

jobs:
pre-commit:
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ It will ask you for your `sudo` password.
### Develop inside the container using VSCode

If you want to develop inside the container using VSCode, you need to have the [Docker extension](https://marketplace.visualstudio.com/items?itemName=ms-azuretools.vscode-docker) installed.
To see option "Attach Visual Studio Code" you also need to download VS Code extenstion Dev Containers.
To see the option "Attach Visual Studio Code", you also need to download the [Dev Containers extension](https://marketplace.visualstudio.com/items?itemName=ms-vscode-remote.remote-containers).

Attach to the container as shown in the image below:

Expand Down